Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(code-interpreter): improve file input prompt #86

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions src/internals/helpers/array.ts
Original file line number Diff line number Diff line change
Expand Up @@ -28,3 +28,11 @@ export function castArray<T>(arr: T) {
const result = Array.isArray(arr) ? arr : [arr];
return result as T extends unknown[] ? T : [T];
}

type HasMinLength<T, N extends number, T2 extends any[] = []> = T2["length"] extends N
? [...T2, ...T[]]
: HasMinLength<T, N, [any, ...T2]>;

export function hasMinLength<T, N extends number>(arr: T[], n: N): arr is HasMinLength<T, N> {
return arr.length >= n;
}
62 changes: 33 additions & 29 deletions src/tools/python/python.ts
Original file line number Diff line number Diff line change
Expand Up @@ -28,13 +28,14 @@ import { z } from "zod";
import { BaseLLMOutput } from "@/llms/base.js";
import { LLM } from "@/llms/llm.js";
import { PromptTemplate } from "@/template.js";
import { differenceWith, isShallowEqual, isTruthy, mapToObj, unique } from "remeda";
import { PythonStorage } from "@/tools/python/storage.js";
import { differenceWith, isShallowEqual, isTruthy, map, unique } from "remeda";
import { PythonFile, PythonStorage } from "@/tools/python/storage.js";
import { PythonToolOutput } from "@/tools/python/output.js";
import { ValidationError } from "ajv";
import { ConnectionOptions } from "node:tls";
import { AnySchemaLike } from "@/internals/helpers/schema.js";
import { RunContext } from "@/context.js";
import { hasMinLength } from "@/internals/helpers/array.js";

export interface CodeInterpreterOptions {
url: string;
Expand Down Expand Up @@ -76,28 +77,36 @@ export class PythonTool extends Tool<PythonToolOutput, PythonToolOptions> {

async inputSchema() {
const files = await this.storage.list();
const fileIds = unique(map(files, ({ id }) => id));

const zodFileId = hasMinLength(files, 2)
? z.union(map(files, (file) => z.literal(file.id).describe(file.filename)))
: hasMinLength(files, 1)
? z.literal(files[0].id).describe(files[0].filename)
: z.undefined();

return z.object({
language: z.enum(["python", "shell"]).describe("Use shell for ffmpeg, pandoc, yt-dlp"),
code: z.string().describe("full source code file that will be executed"),
inputFiles: z
.object(
mapToObj(files, (value) => [
value.id,
z.literal(value.filename).describe("filename of a file"),
]),
)
.partial()
.optional()
.describe(
[
"To access an existing file, you must specify it; otherwise, the file will not be accessible. IMPORTANT: If the file is not provided in the input, it will not be accessible.",
"The key is the final segment of a file URN, and the value is the filename. ",
files.length > 0
? `Example: {"${files[0].id}":"${files[0].filename}"} -- the files will be available to the Python code in the working directory.`
: `Example: {"e6979b7bec732b89a736fd19436ec295f6f64092c0c6c0c86a2a7f27c73519d6":"file.txt"} -- the files will be available to the Python code in the working directory.`,
].join(" "),
),
...(hasMinLength(fileIds, 1)
? {
inputFiles: z
.array(
z.object({
id: zodFileId,
filename: z
.string()
.min(1)
.describe(
"name under which the file will be available to the Python code in the working directory",
),
}),
)
.describe(
"To access an existing file, you must specify it; otherwise, the file will not be accessible. IMPORTANT: If the file is not provided in the input, it will not be accessible.",
),
}
: {}),
});
}

Expand All @@ -107,7 +116,9 @@ export class PythonTool extends Tool<PythonToolOutput, PythonToolOptions> {
): asserts rawInput is ToolInput<this> {
super.validateInput(schema, rawInput);

const fileNames = Object.values(rawInput.inputFiles ?? {}).filter(Boolean) as string[];
const fileNames = (rawInput.inputFiles as { filename: string }[])
?.map(({ filename }) => filename)
.filter(Boolean) as string[];
const diff = differenceWith(fileNames, unique(fileNames), isShallowEqual);
if (diff.length > 0) {
throw new ToolInputValidationError(
Expand Down Expand Up @@ -158,14 +169,7 @@ export class PythonTool extends Tool<PythonToolOutput, PythonToolOptions> {
_options: BaseToolRunOptions | undefined,
run: RunContext<this>,
) {
const inputFiles = await this.storage.upload(
Object.entries(input.inputFiles ?? {})
.filter(([k, v]) => Boolean(k && v))
.map(([id, filename]) => ({
id,
filename: filename!.split(":").at(-1) ?? filename!,
})),
);
const inputFiles = await this.storage.upload((input.inputFiles as PythonFile[]) ?? []);
JanPokorny marked this conversation as resolved.
Show resolved Hide resolved

// replace relative paths in "files" with absolute paths by prepending "/workspace"
const getSourceCode = async () => {
Expand Down
15 changes: 9 additions & 6 deletions src/tools/python/storage.ts
Original file line number Diff line number Diff line change
Expand Up @@ -140,13 +140,16 @@ export class LocalPythonStorage extends PythonStorage {
async upload(files: PythonUploadFile[]): Promise<PythonFile[]> {
await this.init();

const fileList = await this.list();

await Promise.all(
files.map((file) =>
copyFile(
path.join(this.input.localWorkingDir.toString(), file.filename),
path.join(this.input.interpreterWorkingDir.toString(), file.id),
),
),
files.map((file) => {
const filesystemFile = fileList.find((filesystemFile) => filesystemFile.id === file.id)!;
return copyFile(
path.join(this.input.localWorkingDir.toString(), filesystemFile.filename),
path.join(this.input.interpreterWorkingDir.toString(), filesystemFile.id),
);
}),
);
return files.map((file) => ({ ...file, hash: file.id }));
}
Expand Down