Skip to content

Commit

Permalink
[BUILD] Note we don't list/pin all direct dependencies in load_extern…
Browse files Browse the repository at this point in the history
…al.bzl

Fixes google#931

PiperOrigin-RevId: 524132105
  • Loading branch information
cdleary authored and hzeller committed May 19, 2023
1 parent 8e713ef commit 26cc013
Showing 1 changed file with 12 additions and 0 deletions.
12 changes: 12 additions & 0 deletions dependency_support/load_external.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,18 @@ load("//dependency_support/rules_hdl:workspace.bzl", repo_rules_hdl = "repo")
def load_external_repositories():
"""Loads external repositories with third-party code."""

# Note: there are more direct dependencies than are explicitly listed here.
#
# By letting direct dependencies be satisfied by transitive WORKSPACE
# setups we let the transitive dependency versions "float" to satisfy their
# package requirements, so that we can bump our dependency versions here
# more easily without debugging/resolving unnecessary conflicts.
#
# This situation will change when XLS moves to bzlmod. See
# https://github.com/google/xls/issues/865 and
# https://github.com/google/xls/issues/931#issue-1667228764 for more
# information / background.

repo_boost()
repo_llvm()
repo_rules_hdl()
Expand Down

0 comments on commit 26cc013

Please sign in to comment.