Skip to content
This repository has been archived by the owner on Mar 17, 2022. It is now read-only.

- fix locale for emails that are triggered by a paypal ipn message #4

Merged
merged 2 commits into from
Jun 18, 2015

Conversation

nicobea
Copy link
Contributor

@nicobea nicobea commented Jun 17, 2015

Hi,

I noticed that emails that are triggered by an asynchronous PayPal IPN message were not in the correct locale. To fix that I just made some updates to your Emails class inspired from WooCommerce /includes/gateways/paypal/includes/class-wc-gateway-paypal-ipn-handler.php.

Best regards and thanks for the great work!

@hyyan
Copy link
Owner

hyyan commented Jun 17, 2015

@nicobea thank you for the PR , but your method name does not follow the code standard of this plugin could you please change it to something like getOrderIDFromIPNRequest , thanks you 👍

@hyyan
Copy link
Owner

hyyan commented Jun 17, 2015

@nicobea I am using http://cs.sensiolabs.org/ for plugin code standard , you can use it.

@nicobea
Copy link
Contributor Author

nicobea commented Jun 18, 2015

@hyyan, I just made a new commit and I changed the method name as you suggest. I've also removed some extra spaces that are not compliant with the coding standards you use.
Thank you.

hyyan pushed a commit that referenced this pull request Jun 18, 2015
- fix locale for emails that are triggered by a paypal ipn message
@hyyan hyyan merged commit b98afc1 into hyyan:master Jun 18, 2015
@hyyan
Copy link
Owner

hyyan commented Jun 18, 2015

@nicobea Thank you for PR 😄

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants