Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename internal functions #343

Merged
merged 1 commit into from
Nov 12, 2023
Merged

rename internal functions #343

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/_BSplineSpace.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -273,7 +273,7 @@
isnondegenerate(P::BSplineSpace, i::Integer) = isnondegenerate_R(P, i)
isnondegenerate(P::BSplineSpace) = isnondegenerate_R(P)

function _degeneratize_R(P::BSplineSpace{p}) where p
function _nondegeneratize_R(P::BSplineSpace{p}) where p

Check warning on line 276 in src/_BSplineSpace.jl

View check run for this annotation

Codecov / codecov/patch

src/_BSplineSpace.jl#L276 

Added line #L276 was not covered by tests
k = copy(KnotVector(knotvector(P)))
I = Int[]
for i in 1:dim(P)
Expand All @@ -282,7 +282,7 @@
deleteat!(BasicBSpline._vec(k), I)
return BSplineSpace{p}(k)
end
function _degeneratize_I(P::BSplineSpace{p}) where p
function _nondegeneratize_I(P::BSplineSpace{p}) where p
k = copy(KnotVector(knotvector(P)))
l = length(k)
I = Int[]
Expand Down
4 changes: 2 additions & 2 deletions src/_ChangeBasis.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -396,8 +396,8 @@ function _changebasis_I_old(P::BSplineSpace{p,T}, P′::BSplineSpace{p′,T′})
end

function __changebasis_I_old(P1, P2)
_P1 = _degeneratize_I(P1)
_P2 = _degeneratize_I(P2)
_P1 = _nondegeneratize_I(P1)
_P2 = _nondegeneratize_I(P2)
A = _changebasis_I_old(P1,P2)
_A = zero(A)
_A[isnondegenerate_I.(P1,1:dim(P1)), isnondegenerate_I.(P2,1:dim(P2))] = _changebasis_I_old(_P1,_P2)
Expand Down
Loading