Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

baseflow recession added #7

Merged
merged 1 commit into from
May 26, 2024
Merged

baseflow recession added #7

merged 1 commit into from
May 26, 2024

Conversation

gutabeshu
Copy link
Contributor

A class called BaseflowRecession is added to the hydrological signature.

  • Closes #xxxx
  • Tests added and nox passes.
  • Passes pre-commit run --all-files
  • Changes and the contributor name are documented in HISTORY.rst.

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
B Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

@cheginit
Copy link
Contributor

Guta, thanks for adding this, LGTM.

@cheginit cheginit merged commit d5760fa into hyriver:main May 26, 2024
0 of 3 checks passed
@cheginit cheginit mentioned this pull request May 26, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gutabeshu @cheginit