Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typo and check correct grandchild PID in spawn() #34

Merged
merged 1 commit into from
Mar 11, 2024
Merged

Fix typo and check correct grandchild PID in spawn() #34

merged 1 commit into from
Mar 11, 2024

Conversation

lucasreis1
Copy link
Contributor

Some simple fixes to spawn to check the correct PID before displaying error message.

vaxerski
vaxerski approved these changes Mar 11, 2024
View reviewed changes
Copy link
Member

@vaxerski vaxerski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lol the thing is copied from hl so the same bug exists there

@lucasreis1
Copy link
Contributor Author

Oh I'll do a merge request for hyprland too, then

@lucasreis1 lucasreis1 mentioned this pull request Mar 11, 2024
Merged
@vaxerski vaxerski merged commit 4395339 into hyprwm:main Mar 11, 2024
1 check passed
@lucasreis1 lucasreis1 deleted the pr/spawn_fixes branch March 11, 2024 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vaxerski vaxerski vaxerski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lucasreis1 @vaxerski