hyprpm: target installed instead of running version #8634
+59
−20
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your PR, what does it fix/add?
After updating Hyprland,
hyprpm update
will still build plugins against the currently running version of Hyprland.This is a little annoying, because you first have to restart Hyprland and then run
hyprpm update
for your plugins to be built for the correct version.This PR makes
hyprpm
build against the installed version of Hyprland instead of the running version, and shows a popup notification if the running Hyprland version differs from the installed one after updating, telling users to restart Hyprland.Is there anything you want to mention? (unchecked code, possible bugs, found problems, breaking compatibility, etc.)
When I tested it on my setup (Arch) everything worked fine, so no I don't think so. Not sure how Nix handles stuff, but it should work there too I suppose.
I did change the signature of hyprpm's
getHyprlandVersion
func, but gave it a default value of true that corresponds to the original behavior.Is it ready for merging, or does it need work?
Should be ready for merging, although if you have any feedback (e.g. UX wise) go for it