Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xwayland: minor fixups for stability #8323

Merged
merged 3 commits into from
Nov 3, 2024
Merged

Conversation

Trimutex
Copy link
Contributor

@Trimutex Trimutex commented Nov 1, 2024

Describe your PR, what does it fix/add?

  • Fix lock file permissions
  • Ensure sockets are closed safely using inline methods
  • Attempt to recreate XWayland instance on crash

Is there anything you want to mention? (unchecked code, possible bugs, found problems, breaking compatibility, etc.)

Any socket closes swapped from close() to closeSocketSafely() were differences found in wlroots's method.

Is it ready for merging, or does it need work?

Ready

@Trimutex Trimutex changed the title Xwayland xwayland: minor fixups for stability Nov 1, 2024
src/xwayland/XWM.cpp Outdated Show resolved Hide resolved
Copy link
Member

@vaxerski vaxerski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@vaxerski vaxerski merged commit 5833abb into hyprwm:main Nov 3, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants