Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

compositor: add group_on_movetoworkspace #8159

Merged
merged 4 commits into from
Oct 22, 2024

Conversation

Aqa-Ib
Copy link

@Aqa-Ib Aqa-Ib commented Oct 18, 2024

Describe your PR, what does it fix/add?

Adds the option "group_on_movetoworkspace" to be able to configure whether using movetoworkspace[silent] will merge the window into the workspace's solitary unlocked group. Wiki.

Is there anything you want to mention? (unchecked code, possible bugs, found problems, breaking compatibility, etc.)

Fixes #8135

Is it ready for merging, or does it need work?

Ready.

Aqa-Ib pushed a commit to Aqa-Ib/hyprland-wiki that referenced this pull request Oct 18, 2024
@Aqa-Ib Aqa-Ib changed the title layout: add group_on_movetoworkspace compositor: add group_on_movetoworkspace Oct 18, 2024
@Aqa-Ib Aqa-Ib force-pushed the group_on_movetoworkspace branch from 8d61e94 to 929c250 Compare October 18, 2024 12:13
@Aqa-Ib
Copy link
Author

Aqa-Ib commented Oct 18, 2024

This is somewhat alike the previous behavior that dwindle had. Although I am wondering, should we check if the group is the only window in the workspace? I think that would be a more consistent behavior.

@Aqa-Ib
Copy link
Author

Aqa-Ib commented Oct 18, 2024

Done, now its behavior is consistent.
Ready to merge if you like how it works.

@vaxerski
Copy link
Member

I think it should only merge if the group is the only thing on the ws

@Aqa-Ib
Copy link
Author

Aqa-Ib commented Oct 19, 2024

I think it should only merge if the group is the only thing on the ws

It is done, we are checking if there is only one visible window in the workspace.

src/Compositor.cpp Outdated Show resolved Hide resolved
src/layout/IHyprLayout.cpp Outdated Show resolved Hide resolved
@Aqa-Ib Aqa-Ib force-pushed the group_on_movetoworkspace branch 2 times, most recently from e5e6f93 to 19b91e2 Compare October 19, 2024 15:58
@Aqa-Ib Aqa-Ib force-pushed the group_on_movetoworkspace branch from 19b91e2 to 2ad4ba0 Compare October 19, 2024 16:15
Copy link
Member

@vaxerski vaxerski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dzięki

@vaxerski vaxerski merged commit 2b6ff68 into hyprwm:main Oct 22, 2024
12 checks passed
vaxerski pushed a commit to hyprwm/hyprland-wiki that referenced this pull request Oct 22, 2024
* add group_on_movetoworkspace

hyprwm/Hyprland#8159

* update
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Change]: Merge when only grouped window is on workspace
2 participants