Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

textinput: fix tiv3 leave #7761

Merged
merged 1 commit into from
Sep 12, 2024
Merged

Conversation

sungyoonc
Copy link
Contributor

@sungyoonc sungyoonc commented Sep 12, 2024

Describe your PR, what does it fix/add?

Fix #7757

This MR fixes some mistakes from MR #7660.

Is there anything you want to mention? (unchecked code, possible bugs, found problems, breaking compatibility, etc.)

I could make this part a separate MR. Do you prefer that?

if (isV3() && !pV3Input.expired() && pV3Input->current.enabled.value) {
    pV3Input->pending.enabled.value            = false;
    pV3Input->pending.enabled.isDisablePending = false;
    pV3Input->pending.enabled.isEnablePending  = false;
    pV3Input->current.enabled.value            = false;
}

Is it ready for merging, or does it need work?

Ready

Copy link
Member

@vaxerski vaxerski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks :)

@vaxerski vaxerski merged commit 118be4d into hyprwm:main Sep 12, 2024
11 checks passed
@sungyoonc sungyoonc deleted the remove-ti-debug-code branch September 13, 2024 00:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

xwayland: There are two IME popups in JetBrains idea
2 participants