sessionLock: ensure sls focus in some edge cases #7647
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PMONITOR is checked above
A bit of reordering, so that we don't call some stuff that is irrelevant when the session is locked
vaxerski
approved these changes
Sep 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your PR, what does it fix/add?
Fixes hyprwm/hyprlock#460
Fixes #7391
Similar bad behaviour is easily reproduced with "sleep 5 && hyprlock" followed by a switch to another tty. When switching back, hyprlock has no focus and mouse needs to be moved to be able to type.
I think this can happen in some hypridle situations as well.
I also thought it would be a good idea to make the code path in
mouseMoveUnifieda bit more straight forward when the session is locked.Is there anything you want to mention? (unchecked code, possible bugs, found problems, breaking compatibility, etc.)
Please double check the reordering in
mouseMoveUnified.Is it ready for merging, or does it need work?
Ready.