-
-
Notifications
You must be signed in to change notification settings - Fork 897
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
config: add option to enable/disable xwayland #7633
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
will this work at runtime? e.g. if someone enables it while running hl
if yes it'd be nice to also do xwaylanf restore while we at it (restart if crash) |
Yeah, the option is meant to work while Hyprland is running and I want to keep it that way
calling g_pXWayland->reset(), or resetting is members (pServer, pWM) crashes it when disabling due to lingering apps, probably due to the same issue as 2 above |
Unless there is some way to simply test if it crashed that I'm unaware of? That would just be oversight from my part if there's a good way for that |
I think if the wm is yeeten off then it crashed or died |
Update note: This PR currently only prevents creation of new XWayland windows by unsetting the env variable. I'll continue to dig deeper on actually shutting down XWayland and applications with it off. |
Few bugs but currently handles turning off/on multiple times just fine Current Bugs
|
@vaxerski Should be all good now for merge. Leaving steam issue alone as I don't think its an XWayland problem, just would require keeping track of PIDs and killing them. That might be leaking into territory better made for another PR. Additional mention as you asked about it that XWayland should fully restore on re-enable. I can't test that for sure though as I don't have a reliable way of crashing it in such a way that it can't restart. |
Managed to crash XWayland and can confirm this restores successfully! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sankyu!
Describe your PR, what does it fix/add?
Allows enabling and disabling XWayland during runtime. #3371 appears to be stale and not being worked on.
Is there anything you want to mention? (unchecked code, possible bugs, found problems, breaking compatibility, etc.)
Is it ready for merging, or does it need work?
Current state of commit works, but see above for things I would like to address first. Closes #7607