-
-
Notifications
You must be signed in to change notification settings - Fork 897
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add a config to control which window to focus on when closing window #7368
Conversation
This is quite cool. I am not a maintainer nor know C++, but I think using a string like "cursor" and "next" instead of an integer is nicer to understand for the end-user :D |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clang-format and wiki mr needed :)
pls dont |
Pf, strings are nicer |
Apologies for missing the PR guidelines. I've now applied clang-format and updated the wiki(hyprland-wiki/pull/753). Thank you for the feedback! |
@Visual-Dawg Settings like I agree that strings can be more user-friendly, but in this case, I prioritized consistency with existing configurations. |
strings will be parsable in the future once the descriptions branch gets merged (I should merge it) |
ye I merged #7377 can you add your opt to configDescriptions.hpp too? (rebase on main first) |
I've completed the rebase and updated |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rest ok
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for the patience!
clang-format needed |
Describe your PR, what does it fix/add?
This PR introduces a new configuration option,
input::focus_on_close
, which controls the window focus behavior after a window is closed.Given the existing focus-related settings within the
input
category, I have placed this configuration there as well.input::focus_on_close
is an integer, and currently supports two values:getNextWindowCandidate
.The reason for using an integer instead of a boolean is to allow for future extensibility. For example, the option could be extended to focus on the previously focused window, or implement other behaviors, depending on user needs or future contributions.
Is there anything you want to mention? (unchecked code, possible bugs, found problems, breaking compatibility, etc.)
No known issues.
Is it ready for merging, or does it need work?
Yes, it is ready for merging.