fix data race and a unsigned int rollover #7278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mouse keycode is 0, and the switch case checks for 0 - 8 and rolls over, just return early if keycode is 0.
vaxerski
previously approved these changes
Aug 10, 2024
gulafaran
force-pushed
the
ubsan
branch
3 times, most recently
from
3fe5eee
to
3311a68
Compare
vaxerski
previously approved these changes
Aug 11, 2024
vaxerski
reviewed
Aug 11, 2024
asan thread sanitizer reported data races in the watchdog from reading and setting the bool variables make them std::atomic bools. also add a atomic bool for the main thread to wait for to avoid data race when reading the config values.
asan created false positives and didnt like this bit, so for the sake of easier debugging rename it to something unicode.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
just some minor ubsan finds, keycodeToModifier was called with a 0 keycode on mouse keys, and the switch case rolled it over on 0 - 8, no harm but unnecessery.
the watchdog is a seperate thread and hit data races in both reading the config values and reading the bools with the main thread, add a atomic bool for the main thread to wait until the watchdog has read its configvalues so it doesnt hit races in reading the config values with main thread. and change the members to atomic aswell.
also with enabling various ubsan/threadsanitizer/asan flags it gave a few false positives from the non unicode characters in hyprdebug, just change them to a unicode name.