Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xcursmgr add a new setting to sync gsettings #7253

Merged
merged 1 commit into from
Aug 9, 2024

Conversation

gulafaran
Copy link
Contributor

cursor:sync_gsettings_theme is set to default true and if enabled it will now sync xcursor theme loading with gsettings if it can, meaning CSD clients will now also change to the appropiate theme upon start and hyprctl setcursor THEME SIZE .

adds a new linking and dep to GIO

Copy link
Member

@vaxerski vaxerski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rest lgtm, have you tested this?

src/managers/XCursorManager.cpp Show resolved Hide resolved
src/managers/XCursorManager.cpp Outdated Show resolved Hide resolved
cursor:sync_gsettings_theme is set to default true and if enabled it
will now sync xcursor theme loading with gsettings if it can, meaning
CSD clients will now also change to the appropiate theme upon start and
hyprctl setcursor THEME SIZE .
@gulafaran
Copy link
Contributor Author

rest lgtm, have you tested this?

cursor.mp4

@gulafaran
Copy link
Contributor Author

rest lgtm, have you tested this?

oh should the config option be a bool perhaps hm

Copy link
Member

@vaxerski vaxerski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm
wiki mr pls

@vaxerski
Copy link
Member

vaxerski commented Aug 9, 2024

internally bools are ints

@gulafaran
Copy link
Contributor Author

lgtm wiki mr pls

hyprwm/hyprland-wiki#743

@vaxerski vaxerski merged commit 8b37e81 into hyprwm:main Aug 9, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants