refactor fullscreen

[MightyPlaza]

Refactors fullscreen to:

• allow passing directly from any state to any other (e.g. maximized to fullscreen)
• allow fully separating the fullscreen mode hyprland uses and the client sees (e.g. to replace fakefullscreen)

Introduces syncFullscreen to allow enabling and disabling wether the internal and client's state should be the same.
Introduces new dispatcher fullscreenState X Y where X and Y set the internal and the client's fullscreen state respectively (-1 to not alter, 0 for none, 1 for maximized, 2 for fullscreen, 3 for maximized and fullscreen) (using this dispatcher will set value above false).

It's ready for testing and should be fully functional, but still needs some clean up of unused stuff.

should fix #6562
closes #2662

[diniamo]

workspace=f[1], gapsin:0, gapsout:0, border:false, shadow:false, rounding:false, decorate:false <- this workspace rule seems to be broken. It's supposed to disable window decorations for maximized windows.

[MightyPlaza]

should work now

[diniamo]

Yep, all good

[diniamo]

Ok I might be schizo but could this PR have broken anything related to cursors?

[diniamo]

Never mind, it's probably some random commit

[MightyPlaza]

should be finished and ready for review now
hyprwm/hyprland-wiki#730

[vaxerski]

yabba dabba doo

[Shaenamity]

Please allow toggling fullscreenstate if it's already enabled for more convenient, like fakefullscreen used to be.

[MightyPlaza]

Please allow toggling fullscreenstate if it's already enabled for more convenient, like fakefullscreen used to be.

#7128

[The-Lost-Light]

Is it's work with windowrule?
I use fakefullscreen to hide the title in flutter app.
And this rule can't work.

# Flutter Applications
windowrulev2 = fullscreenstate -1 2, class:(localsend)
windowrulev2 = fullscreenstate -1 2, class:(AppFlowy)

[vaxerski]

fakefullscreen = fullscreenstate 0 2 (or 2 0 depending on which fake fullscreen)

[MightyPlaza]

fakefullscreen = fullscreenstate 0 2 (or 2 0 depending on which fake fullscreen)

-1 doesn't work for the window rule and somehow I forgot to even add it to the rules in the wiki PR

[The-Lost-Light]

I try fullscreenstate 0 2 and it works at localsend(and most app)
however, AppFlowy will into fullscreen(not fake)
Edit: AppFlowy weird with any fullscreenstate setting

And i found another problem with the windowrule to set it fakefullscreen, i can't manual toggle it by dispatcher like bind = SUPER SHIFT, F, fullscreenstate, 0 2

[MightyPlaza]

no ,
bind = SUPER SHIFT, F, fullscreenstate 0 2

[The-Lost-Light]

no , bind = SUPER SHIFT, F, fullscreenstate 0 2

[MightyPlaza]

no , bind = SUPER SHIFT, F, fullscreenstate 0 2

you were right, your bind was correct

[MightyPlaza]

I try fullscreenstate 0 2 and it works at localsend(and most app) however, AppFlowy will into fullscreen(not fake) Edit: AppFlowy weird with any fullscreenstate setting

And i found another problem with the windowrule to set it fakefullscreen, i can't manual toggle it by dispatcher like bind = SUPER SHIFT, F, fullscreenstate, 0 2

yeah that doesn't work because current internal state is already 0
for now use bind = SUPER SHIFT, F, fullscreenstate, -1 2

[The-Lost-Light]

I try fullscreenstate 0 2 and it works at localsend(and most app) however, AppFlowy will into fullscreen(not fake) Edit: AppFlowy weird with any fullscreenstate setting
And i found another problem with the windowrule to set it fakefullscreen, i can't manual toggle it by dispatcher like bind = SUPER SHIFT, F, fullscreenstate, 0 2

yeah that doesn't work because current internal state is already 0 for now use bind = SUPER SHIFT, F, fullscreenstate, -1 2

rule: 0 2
bind: -1 2 still not work

rule: 0 3
bind: -1 2 (or 0 2) can work by trans mode(3->2, 2-3 work also)

and AppFlowy weird with any combination

[MightyPlaza]

I try fullscreenstate 0 2 and it works at localsend(and most app) however, AppFlowy will into fullscreen(not fake) Edit: AppFlowy weird with any fullscreenstate setting
And i found another problem with the windowrule to set it fakefullscreen, i can't manual toggle it by dispatcher like bind = SUPER SHIFT, F, fullscreenstate, 0 2

yeah that doesn't work because current internal state is already 0 for now use bind = SUPER SHIFT, F, fullscreenstate, -1 2

rule: 0 2 bind: -1 2 still not work

rule: 0 3 bind: -1 2 (or 0 2) can work by trans mode(3->2, 2-3 work also)

and AppFlowy weird with any combination

I'll see why 1st one doesn't work and some other weird cases later
for now don't use the rule and just use the bind to toggle the state (and reopen the window)

[pdf]

Changing the fullscreen data type from bool to int appears to have been propagated to the socket data structures, making this a breaking change for all external socket clients, and tracking this change down was difficult due to it being marked as an internal refactor in the changelog.

I know it's not always going to be possible, but it would be preferable from a consumer viewpoint to avoid data type changes unless absolutely necessary since it has a flow-on effect for all program logic that consumes the value - a new field might have been introduced (e.g. fullscreenState) to hold the multi-state value, with the existing fullscreen field retaining its bool type to simply indicate whether a window has any positive fullscreen value or not.

[Shaenamity]

Please allow toggling fullscreenstate if it's already enabled for more convenient, like fakefullscreen used to be.

#7128

Thank you