Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move text-input-v1 to hyprwayland-scanner #7096

Merged
merged 2 commits into from
Jul 29, 2024

Conversation

ikalco
Copy link
Contributor

@ikalco ikalco commented Jul 29, 2024

Describe your PR, what does it fix/add?

^

Is there anything you want to mention? (unchecked code, possible bugs, found problems, breaking compatibility, etc.)

tested with chromium --enable-features=UseOzonePlatform --ozone-platform=wayland --enable-wayland-ime
and works the same as before for me

Is it ready for merging, or does it need work?

yes

@ikalco
Copy link
Contributor Author

ikalco commented Jul 29, 2024

im gonna do the last one soon so its possible to remove wayland-scanner from deps in that pr right?

src/protocols/TextInputV1.cpp Outdated Show resolved Hide resolved
src/protocols/TextInputV1.cpp Outdated Show resolved Hide resolved
vaxerski
vaxerski previously approved these changes Jul 29, 2024
Copy link
Member

@vaxerski vaxerski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mashallah brother

@vaxerski
Copy link
Member

ay yo no pch fail lmao

@ikalco
Copy link
Contributor Author

ikalco commented Jul 29, 2024

should be fixed now

@vaxerski vaxerski merged commit 60b663e into hyprwm:main Jul 29, 2024
10 checks passed
@ikalco ikalco deleted the move_textinputv1_impl branch July 29, 2024 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants