-
-
Notifications
You must be signed in to change notification settings - Fork 897
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
move screencopy and toplevel export to hyprwayland-scanner #7065
move screencopy and toplevel export to hyprwayland-scanner #7065
Conversation
btw I saw high mem usage in this pr but i realized it was from last commit diff --git a/src/render/OpenGL.cpp b/src/render/OpenGL.cpp
index 5e52403d..39f6614e 100644
--- a/src/render/OpenGL.cpp
+++ b/src/render/OpenGL.cpp
@@ -2610,6 +2610,8 @@ void CHyprOpenGLImpl::createBackgroundTexture(const std::string& texPath) {
}
#endif
glTexImage2D(GL_TEXTURE_2D, 0, glIFormat, m_pBackgroundTexture->m_vSize.x, m_pBackgroundTexture->m_vSize.y, 0, glFormat, glType, DATA);
+
+ cairo_surface_destroy(CAIROSURFACE);
}
void CHyprOpenGLImpl::createBGTextureForMonitor(CMonitor* pMonitor) { |
8cef421
to
df70333
Compare
lelo thanks will commit that one |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do not have the capacity to test this atm, can you test @fufexan ?
Code looks alr at a glance
Idk what I'm supposed to test tbh. Works normally to me. |
whether sharing works (window, screen, region) |
Yeah all working fine. |
thanks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks!
Describe your PR, what does it fix/add?
moves the screencopy and toplevel export protocol impls to hyprwayland scanner
Is there anything you want to mention? (unchecked code, possible bugs, found problems, breaking compatibility, etc.)
i can split screencopy and toplevel into different PRs if you want cause this is pretty big
Is it ready for merging, or does it need work?
yes