Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move screencopy and toplevel export to hyprwayland-scanner #7065

Merged
merged 2 commits into from
Jul 27, 2024

Conversation

ikalco
Copy link
Contributor

@ikalco ikalco commented Jul 27, 2024

Describe your PR, what does it fix/add?

moves the screencopy and toplevel export protocol impls to hyprwayland scanner

Is there anything you want to mention? (unchecked code, possible bugs, found problems, breaking compatibility, etc.)

i can split screencopy and toplevel into different PRs if you want cause this is pretty big

Is it ready for merging, or does it need work?

yes

@ikalco
Copy link
Contributor Author

ikalco commented Jul 27, 2024

btw I saw high mem usage in this pr but i realized it was from last commit
forgot to free the surface after texturing it

diff --git a/src/render/OpenGL.cpp b/src/render/OpenGL.cpp
index 5e52403d..39f6614e 100644
--- a/src/render/OpenGL.cpp
+++ b/src/render/OpenGL.cpp
@@ -2610,6 +2610,8 @@ void CHyprOpenGLImpl::createBackgroundTexture(const std::string& texPath) {
     }
 #endif
     glTexImage2D(GL_TEXTURE_2D, 0, glIFormat, m_pBackgroundTexture->m_vSize.x, m_pBackgroundTexture->m_vSize.y, 0, glFormat, glType, DATA);
+
+    cairo_surface_destroy(CAIROSURFACE);
 }
 
 void CHyprOpenGLImpl::createBGTextureForMonitor(CMonitor* pMonitor) {

@ikalco ikalco force-pushed the move_to_hyprwayland_scanner_more branch from 8cef421 to df70333 Compare July 27, 2024 08:37
@vaxerski
Copy link
Member

lelo thanks will commit that one

Copy link
Member

@vaxerski vaxerski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not have the capacity to test this atm, can you test @fufexan ?

Code looks alr at a glance

@fufexan
Copy link
Member

fufexan commented Jul 27, 2024

Idk what I'm supposed to test tbh. Works normally to me.

@vaxerski
Copy link
Member

whether sharing works (window, screen, region)

@fufexan
Copy link
Member

fufexan commented Jul 27, 2024

Yeah all working fine.

@vaxerski
Copy link
Member

thanks

Copy link
Member

@vaxerski vaxerski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@vaxerski vaxerski merged commit ec672b1 into hyprwm:main Jul 27, 2024
11 checks passed
@ikalco ikalco deleted the move_to_hyprwayland_scanner_more branch July 27, 2024 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants