-
-
Notifications
You must be signed in to change notification settings - Fork 897
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove toggleopaque #7024
remove toggleopaque #7024
Conversation
modified: src/managers/KeybindManager.cpp modified: src/managers/KeybindManager.hpp
modified: src/managers/KeybindManager.cpp modified: src/managers/KeybindManager.hpp
Is it possible to not push breaking change without a notice ? The command was good, what is the point of pushing such breaking change ? |
there was no need to point in having a dispatcher just to toggle a single window property, since an previous commit allowed toggling other properties like noborder or noshadow like I said above just replace it with on another note, maybe setprop should be added to the dispatchers to not require using hyprctl |
IIRC I announced it on discord. My bad for missing it in the release notes. I should add a tag called "breaking" |
but it was a frequently used function isnt it? what is the cost of having toggleopaque dispatcher anyway. |
Hyprland is a distro known to have lots of breaking changes.
Consistency. That's better than anything else. Someone searching the docs for toggle will now easily find everything they are searching for. |
I found this change really annoying because previously I was toggling certain windows opaque on launch but retaining their opacity settings to change them transparent with hotkey if I want. Trying to do that with hyprctl setprop active doesn't work since there is no guarantee if/when the window I just launched might be active. |
what do you mean? |
removes
toggleopaque
dispatcher in favour ofhyprctl setprop active opaque toggle
needs wiki MR