Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove toggleopaque #7024

Merged
merged 1 commit into from
Jul 24, 2024
Merged

remove toggleopaque #7024

merged 1 commit into from
Jul 24, 2024

Conversation

MightyPlaza
Copy link
Contributor

removes toggleopaque dispatcher in favour of hyprctl setprop active opaque toggle

needs wiki MR

modified:   src/managers/KeybindManager.cpp
modified:   src/managers/KeybindManager.hpp
@MightyPlaza
Copy link
Contributor Author

hyprwm/hyprland-wiki#726

@vaxerski vaxerski merged commit 3f1ddcd into hyprwm:main Jul 24, 2024
11 checks passed
vaxerski pushed a commit that referenced this pull request Jul 24, 2024
modified:   src/managers/KeybindManager.cpp
modified:   src/managers/KeybindManager.hpp
@noahfraiture
Copy link

noahfraiture commented Aug 14, 2024

Is it possible to not push breaking change without a notice ? The command was good, what is the point of pushing such breaking change ?

@MightyPlaza
Copy link
Contributor Author

MightyPlaza commented Aug 14, 2024

Is it possible to not push breaking change without a notice ? The command was good, what is the point of pushing such breaking change ?

there was no need to point in having a dispatcher just to toggle a single window property, since an previous commit allowed toggling other properties like noborder or noshadow

like I said above just replace it with hyprctl setprop active opaque toggle

on another note, maybe setprop should be added to the dispatchers to not require using hyprctl

@vaxerski
Copy link
Member

IIRC I announced it on discord. My bad for missing it in the release notes. I should add a tag called "breaking"

@deng232
Copy link

deng232 commented Aug 21, 2024

Is it possible to not push breaking change without a notice ? The command was good, what is the point of pushing such breaking change ?

there was no need to point in having a dispatcher just to toggle a single window property, since an previous commit allowed toggling other properties like noborder or noshadow

like I said above just replace it with hyprctl setprop active opaque toggle

on another note, maybe setprop should be added to the dispatchers to not require using hyprctl

but it was a frequently used function isnt it? what is the cost of having toggleopaque dispatcher anyway.

@Eclextic
Copy link

Hyprland is a distro known to have lots of breaking changes.

but it was a frequently used function isnt it? what is the cost of having toggleopaque dispatcher anyway.

Consistency. That's better than anything else. Someone searching the docs for toggle will now easily find everything they are searching for.

@shogeki
Copy link

shogeki commented Aug 21, 2024

I found this change really annoying because previously I was toggling certain windows opaque on launch but retaining their opacity settings to change them transparent with hotkey if I want. Trying to do that with hyprctl setprop active doesn't work since there is no guarantee if/when the window I just launched might be active.

@MightyPlaza
Copy link
Contributor Author

I found this change really annoying because previously I was toggling certain windows opaque on launch but retaining their opacity settings to change them transparent with hotkey if I want. Trying to do that with hyprctl setprop active doesn't work since there is no guarantee if/when the window I just launched might be active.

what do you mean?
toggleopaque always used the active window as well
besides you can just use the opaque window rule

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants