Don't simulate mouse movement on focus change in follow_mouse = 2/3 if no_warps is false #7015
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ah clang-format missing lole |
|
@vaxerski would you like a GitHub-action that automatically runs clang-format and makes a commit in the pr (happens every time the pr is updated)? |
|
no |
antonok-edm
force-pushed
the
follow-mouse-warp-scroll-fix
branch
from
24db1c4
to
8e258e9
Compare
|
clang-formatted |
vaxerski
reviewed
Jul 24, 2024
…f no_warps is false
antonok-edm
force-pushed
the
follow-mouse-warp-scroll-fix
branch
from
8e258e9
to
f20bfba
Compare
vaxerski
approved these changes
Jul 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your PR, what does it fix/add?
Fixes #4949
(Technically, it looks like the original issue was fixed already in 7ea555da7, but the case described in my comment is still broken and will be fixed by this PR).
Is there anything you want to mention? (unchecked code, possible bugs, found problems, breaking compatibility, etc.)
I've tested all combinations of
input:follow_mouseandcursor:no_warps; the behavior in this PR seems more consistent with how they're described in all cases.Is it ready for merging, or does it need work?
Ready as far as I'm aware.