Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: option to exit window while retaining fullscreen (#516) #6880

Merged
merged 2 commits into from
Jul 15, 2024

Conversation

nktnet1
Copy link
Contributor

@nktnet1 nktnet1 commented Jul 14, 2024

Describe your PR, what does it fix/add?

Resolves #516 by completing the second (final) point:

when a fullscreen window is being closed and it was not the only window on the current workspace, the next window that gains focus would become the new fullscreen window

This PR introduces a new misc option:

misc { 
    exit_window_retains_fullscreen = true
}

The implementation makes a backup of the current window's fullscreen mode & state, which is then applied to the next window candidate that will gain focus (if any).

Is there anything you want to mention? (unchecked code, possible bugs, found problems, breaking compatibility, etc.)

I think exit_window_retains_fullscreen is a suitable name and belongs in misc as a new variable, although I'm not too familiar with the code base and all available options yet.

Is it ready for merging, or does it need work?

Code-wise, I think it's ready.

Will need to make another pull request for hyprland-wiki if this PR is in the right direction (happy to write the documentation if this gets the green lights).

src/events/Windows.cpp Outdated Show resolved Hide resolved
Copy link
Member

@vaxerski vaxerski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm wiki mr needed

@nktnet1
Copy link
Contributor Author

nktnet1 commented Jul 15, 2024

lgtm wiki mr needed

Documentation has been added here:

Thank you!

@vaxerski vaxerski merged commit bd52682 into hyprwm:main Jul 15, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Opening/closing windows in fullscreen
2 participants