pointer-constraints: keep constraint alive until actual destruction #6679
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
On closer inspection I'm dumb and this of course breaks any oneshot lifetime... However, would using a default of persistent be possible to achieve the same effect of fixing the original issue (the example)? Documentation for it explains both, but not a default for this from what I can find. |
|
tag me when ready |
|
@vaxerski should already be ready? this still fixes the Minecraft example already. Sorry if I didn't make that clear |
|
why not just set the properties in the appropriate constructors like I've obviously forgotten to? xD |
vaxerski
added a commit
that referenced
this pull request
Jun 28, 2024
|
should be fixed. |
|
because I missed it too lol. this does fix it properly, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your PR, what does it fix/add?
Current constraint deactivation kills the constraint even if it tries to reactivate due to lifetime check always being true. Removing this fixes refocusing of windows not actually restarting constraint, requiring a recreation of the constraints by the program.
Possible fix for #5900 but can not recreate issue myself to test.
Is there anything you want to mention? (unchecked code, possible bugs, found problems, breaking compatibility, etc.)
No problems with usage as proper destruction gets called anyways later when actually necessary. Perhaps a better option is to change the default lifetime of the pointer constraint, but I'm not too knowledgeable the implications of that.
Is it ready for merging, or does it need work?
Ready for merging