Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

github: reword bug or regression #6520

Merged
merged 14 commits into from
Jun 18, 2024
Merged

github: reword bug or regression #6520

merged 14 commits into from
Jun 18, 2024

Conversation

Aqa-Ib
Copy link
Contributor

@Aqa-Ib Aqa-Ib commented Jun 15, 2024

I have been watching and a lot of people still don't mark a clear regression. Rewording would fix this, I believe.

@MightyPlaza
Copy link
Contributor

might also be a good idea to ask them to bisect and provide the wiki link https://wiki.hyprland.org/Crashes-and-Bugs/#bisecting-an-issue

@Aqa-Ib
Copy link
Contributor Author

Aqa-Ib commented Jun 15, 2024

Let me know if it can be worded better or clearer (english is not my mother tongue).

Also, do you think that we should give "I don't know" as an option?

fufexan
fufexan previously approved these changes Jun 15, 2024
Copy link
Member

@fufexan fufexan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fufexan
Copy link
Member

fufexan commented Jun 15, 2024

Also, do you think that we should give "I don't know" as an option?

Probably not, as we would still tell them to bisect. It's either yes/no.

Also, we should tell users to also search closed issues, not only open ones.

@MahouShoujoMivutilde
Copy link
Contributor

Maybe something like

  • Bug - This is an unexpected behavior (something is broken).
  • Regression - Like bug, but you also know that it used to work as expected and now doesn't (provide bisect).

?

Because "absent in a previous version" is IMO not as clear - you could read it and be like "of course it was absent, this feature didn't exist".

@Aqa-Ib
Copy link
Contributor Author

Aqa-Ib commented Jun 15, 2024

I understand your concern about a new feature. However, in my opinion, your definition of regression is not simple enough. Feedback is welcome.

@fufexan
Copy link
Member

fufexan commented Jun 16, 2024

@Aqa-Ib what about "Regression - something no longer works in newer versions"?

@Aqa-Ib
Copy link
Contributor Author

Aqa-Ib commented Jun 16, 2024

Done. One thing that is not clear: if we force the users to check for a regression, one can wonder: "how many versions do I have to roll back to check for it?" If we are omitting the "I don't know" option, in my opinion we should clarify this. Maybe 1 or 2 major releases ?

@MightyPlaza
Copy link
Contributor

Done. One thing that is not clear: if we force the users to check for a regression, one can wonder: "how many versions do I have to roll back to check for it?" If we are omitting the "I don't know" option, maybe we should clarify this.

i don't think this matters much
the point is that they write that it's a regression if they know it was working before and now isn't
not go looking for a working commit (this is also a good idea when debugging issues, but not necessary imo)

@Aqa-Ib
Copy link
Contributor Author

Aqa-Ib commented Jun 16, 2024

If that is what we want, then it would make sense for the "I don't know" option to be included. Thoughts?

@fufexan
Copy link
Member

fufexan commented Jun 16, 2024

Done. One thing that is not clear: if we force the users to check for a regression, one can wonder: "how many versions do I have to roll back to check for it?" If we are omitting the "I don't know" option, in my opinion we should clarify this. Maybe 1 or 2 major releases ?

If the user just updated, they should know which version they were on before, and start with that. If they don't, then 1-2 major versions sounds alright.

@Aqa-Ib
Copy link
Contributor Author

Aqa-Ib commented Jun 16, 2024

@vaxerski please, as you are the one that deal with every bug report, when you have a moment do you mind sharing your thoughts on this?

Copy link
Member

@vaxerski vaxerski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rest is ok, I didnt review cuz yall were having a heated discussion

.github/ISSUE_TEMPLATE/bug.yml Outdated Show resolved Hide resolved
@Aqa-Ib
Copy link
Contributor Author

Aqa-Ib commented Jun 17, 2024

@fufexan @MightyPlaza @Agent00Ming would you make a change to improve bug reports ?

@Agent00Ming
Copy link
Contributor

Maybe the command paste thing is a bit obscure but I don't know if we can wrap the user input in a plain text box and treat it with markdown afterwards. Otherwise, it looks as good as it's going to get considering the difficulty that some experience reading a sentence longer than 5 words.

@fufexan
Copy link
Member

fufexan commented Jun 17, 2024

@fufexan @MightyPlaza @Agent00Ming would you make a change to improve bug reports ?

Unsure what we could improve further here.

@Aqa-Ib
Copy link
Contributor Author

Aqa-Ib commented Jun 17, 2024

I found a way to force the user to select yes or no.
At the moment I am exploring simplifying the command paste textbox.

@Aqa-Ib
Copy link
Contributor Author

Aqa-Ib commented Jun 17, 2024

I wasn't able to simplify the command paste textbox. I believe that it is not possible at the moment.

@Aqa-Ib
Copy link
Contributor Author

Aqa-Ib commented Jun 17, 2024

This is ready.

Copy link
Member

@fufexan fufexan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@fufexan fufexan merged commit 236150b into hyprwm:main Jun 18, 2024
11 checks passed
@Aqa-Ib
Copy link
Contributor Author

Aqa-Ib commented Jun 18, 2024

Thank you as always. Wish you all a wonderful day!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants