last bits of asan output #6470
Merged
last bits of asan output #6470
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add destructor and destroy the event source. one less leak on exit of compositor reported by asan.
destruct hyprctl to release the event sources, and properly cleanup the event loop on exit of compositor. less leaks on exit reported by asan
destroy the event source on destruction.
reset the eventloopmanager on exit of compositor and free the leaking last idle frame on monitor destroy.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your PR, what does it fix/add?
with these commits and the hyprutils PR im down to
SUMMARY: AddressSanitizer: 880 byte(s) leaked in 8 allocation(s).of a nested run of opening a few windows/closing and exiting hyprland. making asan VERY silent :) not that these wouldnt have been harvested by the OS anyways but makes asan much more tolerable when trying to debug things. could use a test or two so the eventloopmanager doesnt have to be running at exit? and freeing the idle frame means some artifacting on some weird combination of display destroying.the remaining leaks is gonna be solved when the 3 old protocols gets rewritten to the new way, and when the wlroots/wayland implentation proceeds.