Fix tablet mapping when mapped region is specified #6206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sifmelcara
force-pushed
the
tablet-boundbox
branch
from
7e069c7
to
92907f5
Compare
|
Updated the commit to also account for the case where Tested
with libwacom and multi monitor set-up; my |
When `region_size` is set in the config (non-empty `boundBox`), cursor is mapped to wrong coordinate because `CBox::translate` mutates `TAB->boundBox`, making all subsequent coordinate calculations wrong. This also fixes the edge case where user sets `region_position` but not `region_size`.
sifmelcara
force-pushed
the
tablet-boundbox
branch
from
92907f5
to
a62c851
Compare
Agent00Ming
approved these changes
May 23, 2024
The-Briel-Deal
pushed a commit
to The-Briel-Deal/Hyprland
that referenced
this pull request
May 25, 2024
When `region_size` is set in the config (non-empty `boundBox`), cursor is mapped to wrong coordinate because `CBox::translate` mutates `TAB->boundBox`, making all subsequent coordinate calculations wrong. This also fixes the edge case where user sets `region_position` but not `region_size`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your PR, what does it fix/add?
When
region_positionorregion_sizeis set in the config (non-emptyboundBox), cursor is mapped to wrong coordinate becauseCBox::translatemutatesTAB->boundBox, making all subsequent coordinate calculations wrong.Is there anything you want to mention? (unchecked code, possible bugs, found problems, breaking compatibility, etc.)
Is it ready for merging, or does it need work?
Ready