Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

render fonts with pango, add global font_family config option #6138

Merged
merged 15 commits into from
May 22, 2024

Conversation

rtgiskard
Copy link
Contributor

@rtgiskard rtgiskard commented May 18, 2024

Describe your PR, what does it fix/add?

This resolves: #6073

Is there anything you want to mention? (unchecked code, possible bugs, found problems, breaking compatibility, etc.)

  1. It might be better to allow dynamic apply font_family without restarting Hyprland
  2. the count_missing_glyphs() may not behave as I think, basically works, but not for sure

Is it ready for merging, or does it need work?

Likely to be ready

src/debug/HyprDebugOverlay.cpp Outdated Show resolved Hide resolved
src/debug/HyprDebugOverlay.cpp Outdated Show resolved Hide resolved
src/hyprerror/HyprError.cpp Outdated Show resolved Hide resolved
@vaxerski
Copy link
Member

tag me when it works for review

@rtgiskard
Copy link
Contributor Author

rtgiskard commented May 21, 2024

Ready for review

@rtgiskard rtgiskard requested a review from vaxerski May 21, 2024 11:38
Copy link
Member

@vaxerski vaxerski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rest ok

src/debug/HyprNotificationOverlay.cpp Outdated Show resolved Hide resolved
src/helpers/FontUtils.cpp Outdated Show resolved Hide resolved
src/helpers/FontUtils.hpp Outdated Show resolved Hide resolved
@rtgiskard rtgiskard requested a review from vaxerski May 21, 2024 14:00
vaxerski
vaxerski previously approved these changes May 21, 2024
Copy link
Member

@vaxerski vaxerski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@rtgiskard
Copy link
Contributor Author

wait, my bad ..

@vaxerski
Copy link
Member

lol

@rtgiskard
Copy link
Contributor Author

rtgiskard commented May 21, 2024

lol

🫣 should be ready this time

vaxerski
vaxerski previously approved these changes May 21, 2024
Copy link
Member

@vaxerski vaxerski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@vaxerski
Copy link
Member

needs a wiki mr

@rtgiskard
Copy link
Contributor Author

needs a wiki mr

Here you are: hyprwm/hyprland-wiki#658

@rtgiskard rtgiskard requested a review from vaxerski May 22, 2024 04:19
Copy link
Member

@vaxerski vaxerski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

life is life

@vaxerski vaxerski merged commit 93fea89 into hyprwm:main May 22, 2024
10 checks passed
@rtgiskard rtgiskard deleted the font.pango branch May 22, 2024 10:34
The-Briel-Deal pushed a commit to The-Briel-Deal/Hyprland that referenced this pull request May 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

allow to set a global font, and render with pango only
2 participants