-
-
Notifications
You must be signed in to change notification settings - Fork 936
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make hyprctl setcursor better (support XCursor themes, also give fail message) #6097
Conversation
shit aint compilin doe |
|
sorry I skim over long ass descriptions havent caught that, mark it as draft if it depends on something and link the deps |
ummm, how do I make build work with hyprcursor-git or jus wait |
remind me later tomorrow if I forget to make a new hc release, then we bump the nix flake and wait for arc lonix |
reminder |
thanks! done. @fufexan can you bump the flake here? then we just wait for arc |
should be gtg now |
171072b
to
6fe2c46
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
…sage) (hyprwm#6097) * add support for changing to X cursor themes * use new hyprcursor abi for options * remove unneeded struct
…sage) (hyprwm#6097) * add support for changing to X cursor themes * use new hyprcursor abi for options * remove unneeded struct
Describe your PR, what does it fix/add?
makes it so that hyprctl setcursor can be used to change cursor theme between Hyprcursor and Xcursor
also addresses these issues
setcursor doesn't apply immediately #4221, by removing this code
Hyprland/src/managers/CursorManager.cpp
Lines 269 to 270 in de9798f
hyrctl setcursor should throw error if cursor theme doesn't exist #5232, and adding this too
Hyprland/src/debug/HyprCtl.cpp
Lines 1066 to 1069 in deb7c4f
Is there anything you want to mention? (unchecked code, possible bugs, found problems, breaking compatibility, etc.)
This PR also requires a change in hyprcursor, see hyprwm/hyprcursor#43
The git blame for these lines is for a bug fix, but I believe this was left over when CursorManager was later changed?
either way code should still work the same, just a little less efficient i guess
Hyprland/src/managers/CursorManager.cpp
Lines 269 to 270 in de9798f
Is it ready for merging, or does it need work?
No, I need to get hyprcursor PR merged first (hyprwm/hyprcursor#43)
tested on my machine