togglegroup ipc event added when create/destroy-ing window groups #5866
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vaxerski
reviewed
May 4, 2024
VPavliashvili
force-pushed
the
ipc-togglegroup
branch
2 times, most recently
from
3fa47ed
to
6e66d3d
Compare
VPavliashvili
force-pushed
the
ipc-togglegroup
branch
from
6e66d3d
to
104b700
Compare
|
PR request sent to hyrpland-wiki repo |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your PR, what does it fix/add?
I found myself in a need of a IPC event of creating or destroying window groups. I read the ipc wiki article and saw this feature was missing
This PR will add new
togglegroupIPC event which will return 0/1 after creating or destroying a window groupIs there anything you want to mention? (unchecked code, possible bugs, found problems, breaking compatibility, etc.)
Nothing specifically mentioned in question but this PR resolves #5687 issue
Is it ready for merging, or does it need work?
Should be ready for merge without conflicts