-
-
Notifications
You must be signed in to change notification settings - Fork 897
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add count group flag in windowCount workspace selector prop #5499
Conversation
why not integrate it with w? |
How about this? |
okay, but I don't get why you're doing all that refactoring outside of what you are adding. I'd rather it wasn't there. |
0e0c289
to
8f95719
Compare
Removed all the refactoring bits. Should I make a separate mr or just scrap it? In the current state, making a window into a group doesn't update other windows in that workspace. |
No, they are fine, just unrelated to this MR. Feel free to make it separately |
can you make a wiki mr? |
hyprwm#5499) * Add groupCount workspace selector prop * Intergrate groupCount with windowCount
Hmm, coming back to this now that it is in... Are there any sets of selectors I can use that match tiled(windows+groups) = ? (I guess you can kinda do it with multiple workspace rules?) |
I think mixed counting flag(non grouped window + groups) need to be added to support that. |
Describe your PR, what does it fix/add?
Adds the groupCount workspace selector prop.
The groupCount is the same as the windowCount but it counts groups instead of windows in a workspace.
Resolves #5488
Workspace rules can now do
workspace = g[t1], bordersize:10
Is there anything you want to mention? (unchecked code, possible bugs, found problems, breaking compatibility, etc.)
A comment here shows an example using windowCount with range
0-4
. But this is invalid according to the code. Did you meant to make0-4
a valid range or just typo in the comment?// w - windowCount: w[0-4] or w[1], optional flag t or f for tiled or floating, e.g. w[t0-1]
Is it ready for merging, or does it need work?
Ready, but wiki mr needed.