add input:kb_file option to use a .xkb file. #548
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your PR, what does it fix/add?
The PR adds an option to add a .xkb file as your layout instead of using the existing 5 xkb options.
When the option is set to a valid file, it doesn't use the other xkb options.
When the option is set to null or fails, it uses the other xkb options.
Is there anything you want to mention? (unchecked code, possible bugs, found problems, breaking compatibility, etc.)
absolutePath
in order to reduce duplicated code but wasn't sure where to put it so I kept it inConfigManager
. This is probably not smart to do, but because I'm not familiar with c++, I wasn't sure where to put it.Is it ready for merging, or does it need work?
From what I tested it works.
Tested: