renderer: Add dimaround layer rule #4643
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vaxerski
reviewed
Feb 8, 2024
TheOnlyMrCat
force-pushed
the
layer_dimaround
branch
from
5288808
to
d90cc45
Compare
|
stalling until #4656 is merged (will cause conflicts otherwise), sorry |
TheOnlyMrCat
force-pushed
the
layer_dimaround
branch
from
d90cc45
to
73b7fbf
Compare
TheOnlyMrCat
force-pushed
the
layer_dimaround
branch
from
73b7fbf
to
76cc825
Compare
|
I've rebased onto main; should be ready to go now. |
vaxerski
reviewed
Apr 1, 2024
TheOnlyMrCat
force-pushed
the
layer_dimaround
branch
from
76cc825
to
84fca7f
Compare
vaxerski
reviewed
Apr 1, 2024
TheOnlyMrCat
force-pushed
the
layer_dimaround
branch
from
84fca7f
to
f20a2ea
Compare
|
I've fixed the above. (Thanks for helping me with my admittedly patchy C++ knowledge) |
vaxerski
reviewed
Apr 10, 2024
TheOnlyMrCat
force-pushed
the
layer_dimaround
branch
from
f20a2ea
to
28404e4
Compare
|
wiki mr pls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your PR, what does it fix/add?
I literally just copied the code from the dimaround window rule and it seems to work.
Fixes #1657, Fixes #1889
Is there anything you want to mention? (unchecked code, possible bugs, found problems, breaking compatibility, etc.)
Probably related to #3633. The same weird behaviour that shows up when applying
dimaroundto tiled windows would also happen here for shells on the same layer. There'd also be double-dimaround if there are any dimaround windows behind the layer.Is it ready for merging, or does it need work?
It is ready for merging.