Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Group/Tab Rework #1580

Merged
merged 2 commits into from
Feb 19, 2023
Merged

Group/Tab Rework #1580

merged 2 commits into from
Feb 19, 2023

Conversation

vaxerski
Copy link
Member

Reworks how groups work internally, making them independent of layouts, allows for floating them, etc.

Fixes: #1576 #770
Closes: #593 (impossible to achieve, superseded)

Breaking changes:
dwindle:col.group... -> general:col.group...

Behavior changes:

  • groups are now always created as singular (they don't "eat" neighbors)

@vaxerski vaxerski requested a review from fufexan February 19, 2023 16:16
@fufexan
Copy link
Member

fufexan commented Feb 19, 2023

Found a bug.

  1. Group 2 windows while in dwindle.
  2. Switch to master.
  3. Open a new window. It will be behind the group (but focused) until you move the group, afterwards they get tiled.
  4. Play with tile/fload. Now the group sits in an awkward position, not being able to be tiled again.
  5. Fullscreen/unfullscreen the group. Now it won't even be visible anymore. (optional)
  6. Switch to dwindle again. Group is visible and tiled again.

Basically it's borked on master, but works fine on dwindle.

@vaxerski
Copy link
Member Author

was a hard ASan fault for me, fixed now and can't repro your bug. Check plox.

Copy link
Member

@fufexan fufexan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nailed it boss.

@vaxerski
Copy link
Member Author

cheers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tabbed windows disappears if layout is changed from dwindle to master
2 participants