Implement orientation (placement of master area) for master layout #1202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vaxerski
reviewed
Dec 10, 2022
vaxerski
reviewed
Dec 10, 2022
vaxerski
reviewed
Dec 10, 2022
vaxerski
reviewed
Dec 10, 2022
vaxerski
reviewed
Dec 10, 2022
vaxerski
reviewed
Dec 10, 2022
vaxerski
reviewed
Dec 10, 2022
vaxerski
reviewed
Dec 10, 2022
vaxerski
reviewed
Dec 10, 2022
|
thanks! really cool. Left some minor code quality comments. |
This implement a per workspace 'orientation' that can be set to left, right, top or bottom. Reflecting placement of the master area. Left (default) and right are horizontal layouts, top and bottom produce vertical layouts. Orientation can be switched with: 'hyprctl dispatch layoutmsg orientationleft'
vaxerski
reviewed
Dec 10, 2022
|
I'll trust you that you tested it |
|
Make a wiki MR with the new opt and msgs please inb4 I merge it |
spikespaz
pushed a commit
to spikespaz-contrib/hyprland
that referenced
this pull request
Dec 12, 2022
…yprwm#1202) * Implemented choosing placement of master area (hyprwm#1059) This implement a per workspace 'orientation' that can be set to left, right, top or bottom. Reflecting placement of the master area. Left (default) and right are horizontal layouts, top and bottom produce vertical layouts. Orientation can be switched with: 'hyprctl dispatch layoutmsg orientationleft'
spikespaz
pushed a commit
to spikespaz-contrib/hyprland
that referenced
this pull request
Dec 12, 2022
…yprwm#1202) * Implemented choosing placement of master area (hyprwm#1059) This implement a per workspace 'orientation' that can be set to left, right, top or bottom. Reflecting placement of the master area. Left (default) and right are horizontal layouts, top and bottom produce vertical layouts. Orientation can be switched with: 'hyprctl dispatch layoutmsg orientationleft'
scorpion-26
pushed a commit
to scorpion-26/Hyprland
that referenced
this pull request
Dec 15, 2022
…yprwm#1202) * Implemented choosing placement of master area (hyprwm#1059) This implement a per workspace 'orientation' that can be set to left, right, top or bottom. Reflecting placement of the master area. Left (default) and right are horizontal layouts, top and bottom produce vertical layouts. Orientation can be switched with: 'hyprctl dispatch layoutmsg orientationleft'
This was referenced Dec 20, 2022
spikespaz
pushed a commit
to spikespaz-contrib/hyprland
that referenced
this pull request
Dec 25, 2022
…yprwm#1202) * Implemented choosing placement of master area (hyprwm#1059) This implement a per workspace 'orientation' that can be set to left, right, top or bottom. Reflecting placement of the master area. Left (default) and right are horizontal layouts, top and bottom produce vertical layouts. Orientation can be switched with: 'hyprctl dispatch layoutmsg orientationleft'
spikespaz
pushed a commit
to spikespaz-contrib/hyprland
that referenced
this pull request
Jan 13, 2023
…yprwm#1202) * Implemented choosing placement of master area (hyprwm#1059) This implement a per workspace 'orientation' that can be set to left, right, top or bottom. Reflecting placement of the master area. Left (default) and right are horizontal layouts, top and bottom produce vertical layouts. Orientation can be switched with: 'hyprctl dispatch layoutmsg orientationleft'
spikespaz
pushed a commit
to spikespaz-contrib/hyprland
that referenced
this pull request
Jan 20, 2023
…yprwm#1202) * Implemented choosing placement of master area (hyprwm#1059) This implement a per workspace 'orientation' that can be set to left, right, top or bottom. Reflecting placement of the master area. Left (default) and right are horizontal layouts, top and bottom produce vertical layouts. Orientation can be switched with: 'hyprctl dispatch layoutmsg orientationleft'
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your PR, what does it fix/add?
This implements the idea I posted in #1059 to make the master layout more friendly for use on vertical monitors. Each workspace now has an
orientationwhich states where the master area should be (I opted for the more generic termorientationrather thanmasterplacement). The values can beleft(default, so nothing changes for existing configurations),top,rightandbottom.For the layoutmsg dispatcher the following commands are added:
Here's a screenshot of a vertical monitor using the bottom orientation, with the master area at the bottom, and two slave windows on top:
Is there anything you want to mention? (unchecked code, possible bugs, found problems, breaking compatibility, etc.)
Should be good to go.
Is it ready for merging, or does it need work?
Tested to the best of my ability and ready for merging