Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

blur xray for layers #1158

Merged
merged 2 commits into from
Dec 4, 2022
Merged

blur xray for layers #1158

merged 2 commits into from
Dec 4, 2022

Conversation

FlafyDev
Copy link
Contributor

@FlafyDev FlafyDev commented Dec 3, 2022

Describe your PR, what does it fix/add?

Makes blur_xray xray all surfaces.

This PR makes blur_new_optimizaitons work for every surface and not only windows so would probably require some testing.

Is there anything you want to mention? (unchecked code, possible bugs, found problems, breaking compatibility, etc.)

From want I tried it works fine.

Is it ready for merging, or does it need work?

It works rn so ready for merging/testing.

@FlafyDev FlafyDev changed the title blur xray layers blur xray for layers Dec 3, 2022
@vaxerski
Copy link
Member

vaxerski commented Dec 3, 2022

using blur optimizations for layers below the window layer will result in graphical artifacts. Furthermore, why?

@FlafyDev
Copy link
Contributor Author

FlafyDev commented Dec 3, 2022

using blur optimizations for layers below the window layer will result in graphical artifacts. Furthermore, why?

Oh, so should I add a property to SRenderData that prevents USENEWOPTIMIZE from being true and enable it for background and bottom layers?

And as for the why, same reason that blur_xray exists for windows: optimization
I am animating a layer shell in the top layer and it's slow rn since blur_xray doesn't work for layers. Also it looks bad being able to see the window behind imo.

2022-12-03.20-33-09.mp4

@vaxerski
Copy link
Member

vaxerski commented Dec 3, 2022

If you make it disabled for bottom and background layers it's ok.

@FlafyDev
Copy link
Contributor Author

FlafyDev commented Dec 4, 2022

If you make it disabled for bottom and background layers it's ok.

done. added blockBlurOptimization that is enabled only for layers at the bottom or the background.

@vaxerski vaxerski merged commit ffc580d into hyprwm:main Dec 4, 2022
@FlafyDev FlafyDev deleted the blur-xray-layers branch December 4, 2022 21:56
fufexan pushed a commit that referenced this pull request Dec 5, 2022
* feat: apply blur_xray to non window surfaces

* don't blur optimize bottom and background layers
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants