-
-
Notifications
You must be signed in to change notification settings - Fork 897
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add nofullscreen to windowrules #1107
Conversation
I think it would be way more useful if this only disabled the app requesting fullscreen, and not fullscreen altogether. If the user uses a keybind to toggle fullscreen, why should we not allow them to do so? |
Sure, we can also do that instead. |
Ye |
Make a wiki MR and I'll merge this. Thanks! |
Describe your PR, what does it fix/add?
Provides the ability to disable fullscreen mode for applications.
Most used for applications that request this for no reason.
-> potentially fixes #1074
Is there anything you want to mention? (unchecked code, possible bugs, found problems, breaking compatibility, etc.)
I Have tested this in debug mode and with a few applications, more testing is always welcome.
Is it ready for merging, or does it need work?
A quick check whether or not I have left out some edge cases and if the rule is done properly, just applied the way the other rules were applied.