Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add nofullscreen to windowrules #1107

Merged
merged 6 commits into from
Nov 26, 2022
Merged

Add nofullscreen to windowrules #1107

merged 6 commits into from
Nov 26, 2022

Conversation

DashieTM
Copy link
Contributor

@DashieTM DashieTM commented Nov 26, 2022

Describe your PR, what does it fix/add?

Provides the ability to disable fullscreen mode for applications.
Most used for applications that request this for no reason.
-> potentially fixes #1074

Is there anything you want to mention? (unchecked code, possible bugs, found problems, breaking compatibility, etc.)

I Have tested this in debug mode and with a few applications, more testing is always welcome.

Is it ready for merging, or does it need work?

A quick check whether or not I have left out some edge cases and if the rule is done properly, just applied the way the other rules were applied.

@vaxerski
Copy link
Member

I think it would be way more useful if this only disabled the app requesting fullscreen, and not fullscreen altogether. If the user uses a keybind to toggle fullscreen, why should we not allow them to do so?

@DashieTM
Copy link
Contributor Author

DashieTM commented Nov 26, 2022

Sure, we can also do that instead.
Are all the calls to setWindowFullscreen from the requests in windows.cpp?

@vaxerski
Copy link
Member

Are all the calls to setWindowFullscreen from the requests in windows.cpp?

Ye

src/events/Windows.cpp Outdated Show resolved Hide resolved
src/events/Windows.cpp Outdated Show resolved Hide resolved
src/events/Windows.cpp Outdated Show resolved Hide resolved
src/events/Windows.cpp Outdated Show resolved Hide resolved
@vaxerski
Copy link
Member

Make a wiki MR and I'll merge this. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The firefox window has strange behavior then closes
2 participants