xwayland: verify new xsurf is valid in prop reads

fixes #6250
hyprwm · May 29, 2024 · a60c728 · a60c728
1 parent ebf2587
commit a60c728
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/src/xwayland/XWM.cpp b/src/xwayland/XWM.cpp
@@ -210,7 +210,7 @@ void CXWM::readProp(SP<CXWaylandSurface> XSURF, uint32_t atom, xcb_get_property_
             const auto XID   = (xcb_window_t*)xcb_get_property_value(reply);
             XSURF->transient = XID;
             if (XID) {
-                if (const auto NEWXSURF = windowForXID(*XID); !lookupParentExists(XSURF, NEWXSURF)) {
+                if (const auto NEWXSURF = windowForXID(*XID); NEWXSURF && !lookupParentExists(XSURF, NEWXSURF)) {
                     XSURF->parent = NEWXSURF;
                     NEWXSURF->children.push_back(XSURF);
                 } else