Add a helper function for writing parameterized JS tests #3224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mocha lacks built-in support [1] for writing parameterized tests and the suggested solution [2] involves a bunch of boilerplate* which has IMO resulted in different styles of parameterized tests in our codebase and not having parameterized tests when they would be useful to attain more complete coverage. This adds a helper inspired by [3] for writing parameterized tests and switches several existing places in our code to use it. * Though less with ES2015 syntax. [1] mochajs/mocha#1454 [2] https://mochajs.org/#dynamically-generating-tests [3] https://github.com/lawrencec/Unroll
Current coverage is
|
|
Nice and simple solution! LGTM. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mocha lacks built-in support [1] for writing parameterized tests and the
suggested solution [2] involves a bunch of boilerplate which has IMO
resulted in different styles of parameterized tests in our codebase and
not having parameterized tests when they would be useful to attain more
complete coverage.
This adds a helper inspired by [3] for writing parameterized tests and
switches several existing places in our code to use it.
[1] mochajs/mocha#1454
[2] https://mochajs.org/#dynamically-generating-tests
[3] https://github.com/lawrencec/Unroll