Merge pull request #4441 from hypothesis/remove-homepage-inline-script

Replace inline script for homepage Via form
hypothesis · Mar 17, 2017 · 851913a · 851913a
2 parents 5654ce3 + 96b07d7
commit 851913a
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 4 deletions.
diff --git a/h/static/scripts/legacy-site.js b/h/static/scripts/legacy-site.js
@@ -30,3 +30,14 @@ if (chromeextInstaller) {
     event.preventDefault();
   });
 }
+
+const viaForm = document.querySelector('.js-via-form');
+if (viaForm) {
+  viaForm.addEventListener('submit', (event) => {
+    const url = event.target.elements.url.value;
+    if (url !== '') {
+      window.location.href = 'https://via.hypothes.is/' + url;
+    }
+    event.preventDefault();
+  });
+}
diff --git a/h/templates/home.html.jinja2 b/h/templates/home.html.jinja2
@@ -133,12 +133,14 @@
                 </span>
 
                 <em class="or hidden-xs">Or...</em>
-                <form class="via" onsubmit="url = document.getElementById('search').value; if (url != '') { window.location.href = 'https://via.hypothes.is/h/' + url; } return false;">
+                <form class="via js-via-form">
                   <span class="input-group"
                         title="Insert a URL to annotate that page.">
-                    <input id="search" class="form-control" type="text"
-                            name="search" placeholder="Paste a link...">
-                    <span class="input-group-btn" data-via-button="">
+                    <input class="form-control"
+                           type="text"
+                           name="url"
+                           placeholder="Paste a link...">
+                    <span class="input-group-btn">
                       <button class="btn btn-primary" type="submit">
                         Annotate!
                       </button>