Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure continuous integration triggers on PR created from forks #1807

Merged
merged 1 commit into from
Dec 2, 2024

Conversation

acelaya
Copy link
Contributor

@acelaya acelaya commented Dec 2, 2024

Update the continuous integration workflow so that it triggers when pushing to main branch, but also when creating a pull request.

So far we were running it only when pushing to any branch, which was fine for PRs created directly from this repository.

However, if a PR was created from a fork, continuous integration would not trigger. Now it should.

Copy link

codecov bot commented Dec 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (8f08381) to head (930b699).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #1807   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           68        68           
  Lines         1234      1234           
  Branches       468       468           
=========================================
  Hits          1234      1234           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@acelaya acelaya merged commit d25366f into main Dec 2, 2024
4 checks passed
@acelaya acelaya deleted the ci-on-pr branch December 2, 2024 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants