Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update lock icon #1774

Merged
merged 1 commit into from
Nov 12, 2024
Merged

Update lock icon #1774

merged 1 commit into from
Nov 12, 2024

Conversation

acelaya
Copy link
Contributor

@acelaya acelaya commented Nov 11, 2024

Part of hypothesis/product-backlog#1597

In preparation to add icons for group types, this PR updates the lock icon to the one used in the group types designs, which is also intended to replace the existing lock icon.

Before:
lock-icon-before

After:
lock-icon-after

The lock icon was only used in a couple places in client. This is how the old vs new icons look.

Private annotation: Before vs after
private-anno-before
private-anno-after

☝🏼 This requires a few tailwind classes adjustments

Only for me: Before vs after
post-only-me-before
post-only-me-after

Share tab: Before vs after
share-tab-before
image

☝🏼 This requires a few tailwind classes adjustments

Additionally, this PR deprecates the lock-alt and lock-alt-filled icons, which we don't seem to be using anywhere.

image

Copy link

codecov bot commented Nov 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (89498a0) to head (91d4822).
Report is 6 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #1774   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           67        67           
  Lines         1204      1204           
  Branches       455       455           
=========================================
  Hits          1204      1204           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@acelaya acelaya merged commit 807a340 into main Nov 12, 2024
4 checks passed
@acelaya acelaya deleted the update-lock-icon branch November 12, 2024 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants