Make Select button main content grow #1767
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes the content provided as
buttonContentto aSelectorMultiSelectcomponent take all available space, except for the chevron.This allows to pass a flex container to
buttonContentand allow to place items at the end, right before the chevron icon.Before:
toggle-button-left-2024-11-05_12.16.54.mp4
After:
toggle-button-grow-2024-11-05_12.16.11.mp4
The first use case for this is displaying a badge with the amount of items in the listbox, in the LMS dashboard filters.
Without this, we can only display the badge right after the text, and this would allow to "push" this badge to the end, right before the chevron.
It may be possible to work around this limitation applying other CSS properties in consuming code, but I haven't found one which works consistently and doesn't feel a bit hackier than this.