Prevent accidental miss-clicks outside multi-select checkboxes #1704
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have experienced (and more people has reported) that it is easy to miss-click outside a checkbox on a
MultiSelect
option. This is problematic, because clicking on a checkbox appends/removes the item to the selection, but clicking outside of it is captured as a click on the main option's body, causing the whole selection to be replaced with just that option.multi-select-current-2024-09-06_11.00.31.mp4
This PR changes that behavior, so that clicking on "the surroundings" of the checkbox behaves as clicking the checkbox itself.
"The surroundings" in this case means anywhere inside the right side of the option, matching the option's padding. That way the checkbox is always clicked if you click anywhere on the "right" side of an option.
This shows how it behaves with these changes:
multi-select-fixed-2024-09-06_11.13.12.mp4
Note
This PR is easier to review ignoring whitespaces
Test steps
make dev
.