Use placehold.co to generate placeholder images

[acelaya]

We were using placekitten.com to generate placeholder images, but the service is no longer available.

This PR replaces that service with https://placehold.co, which generates a bit more boring images, but should work as a valid replacement.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (a9630cf) to head (f35245a).
Report is 1 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff            @@
##              main     #1656   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           61        61           
  Lines         1040      1040           
  Branches       402       402           
=========================================
  Hits          1040      1040           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[robertknight]

This is better than dead URLs, although it would be nice to have placeholders that allow you to see if the border gets cropped easily.

[acelaya]

This is better than dead URLs, although it would be nice to have placeholders that allow you to see if the border gets cropped easily.

Yep, that was my thinking, but I couldn't find a service returning "actual" images. Most follow this pattern of returning an image with the size in the middle.

I found one returning random images from flickr. I thought that was a no go 😅

[robertknight]

Yep, that was my thinking, but I couldn't find a service returning "actual" images. Most follow this pattern of returning an image with the size in the middle.

I discovered https://picsum.photos in my travels.

[acelaya]

There's one thing we could do though. We always use the 400x400 size, except in one test where we use the 300x300 one.

I have the suspicion the test one is not important, and for the others, we could just have a locally-stored image. There's no need for an external service to always use the same image.

[acelaya]

Yep, that was my thinking, but I couldn't find a service returning "actual" images. Most follow this pattern of returning an image with the size in the middle.

I discovered https://picsum.photos in my travels.

Hah! This one is nice