-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(configuration page): add createupvelc and editupvelc actions #2044
Conversation
src/pages/dho/Configuration.vue
Outdated
@@ -265,7 +265,7 @@ export default { | |||
communityVotingEnabled: form.communityVotingEnabled ? 1 : 0, | |||
upvoteHeadDelegateRound: form.upvoteHeadDelegateRound ? 1 : 0, | |||
|
|||
upvoteStartDateTime: new Date(`${upvoteStartDate.replace(/\//g, '-')}T${upvoteStartTime}:00.000${timezoneHours}:${timezoneMinutes}`).toISOString(), | |||
upvoteStartDateTime: new Date(`${upvoteStartDate.replace(/\//g, '-')}T${upvoteStartTime}:00.000${timezoneHours}:${timezoneMinutes}`).toISOString().replace('Z', ''), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing upvoteStartDate would break the app. Ensure that it is present or use optional chaining. In general this formatting should be extracted into utility function and reused wherever we need to format the date in the same way.
src/store/dao/actions.js
Outdated
} | ||
] | ||
: []), | ||
...(daoSettings.upvoteElectionId && data.communityVotingMethod === 'UPVOTE' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please use constant for UPVOTE
instead of a string. That constant should be used wherever you need this UPVOTE
value
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we refactor or use in the same file ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If it is used just here, then it can be just in this file. However, in most cases it is the best to have constants shared. I think for this instance, you can update just this file, create global constants and make a new task to refactor.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
* feat(mobile): add multi sig styles (#1997) * fix(proposal): remove edit button (#2006) * feat(login-view): add redirect when login via onboard (#2005) * fix(plan-manager): add correct linking for manage plan buttons (#2004) * fix(top-navigation): remove plan manager button (#2003) * fix(documentation-url): add dynamic links (#2002) * ci: remove documentation url from build (#2001) * refactor(calendar): return to quesar calendar (#2000) * feat(app-styl): add components module (#1996) * fix(comment-item): comment time since formating has been fixed (#1998) (#2008) * fix(proposal-detail): url preview (#1999) (#2009) * feat(badges): update card layout (#1981) (#2011) * feat(configuration-page): add community tab (#2013) * fix(style): rename rounded-corners to the rounded-full (#2016) * fix(badges): filter badge holders by dao (#2010) (#2014) * fix(badges): displaying active badges in dao page (#2018) (#2025) * fix(voting): vote button not visible in mobile design (#2019) (#2024) * fix(refactor): remove home page repeated template code * Revert "fix(refactor): remove home page repeated template code" This reverts commit 355d382. * fix(refactor): remove home page repeated template code (#2031) * fix(mobile): configration templates (#2030) * fix(mobile): general settings layout * fix(mobile): voting settings layout * fix(mobile): design settings layout * fix(mobile): plan settings layout * fix(mobile): communication config toggle * fix(mobile): buy token buttons * feat(members): add community filter (#2035) * feat/upvote election flow (#2037) * feat(upvote-delegate-widget): added new upvote-delegate-widget with title and counter (#1943) * feat(upvote-delegate-widget): added user-card without icon and tag (#1943) * feat(upvote-delegate-widget): added head delegate tag and address-card icon (#1943) * feat(upvote-delegate-widget): update component story file (#1943) * feat(creation-stepper): added new prop title * feat(upvote-election): added new upvote-election route with sign-up screen (#1940) * feat(upvote-election): added new screen round-1 (#1940) * feat(upvote-election): added new screen chief delegates round (#1940) * feat(upvote-election): added new screen head delegate (#1940) * feat(upvote-election): added new screen results (#1940) * feat(upvote-election-banner): added upvote election banner(#1939) * fix(assets): assets grid after merge * feat(upvote-election): integrate graphql api for election * feat(upvote-election): integrate voting logic (intermediate commit) --------- Co-authored-by: Arsenije Savic <[email protected]> * fix: remove console.log (#2038) * fix/upvote election bugs (#2042) * fix(upvote-election): ability to unselect user and passing count (#2041) * fix(upvote-election): revoke action and one style bug * feat(configuration page): add createupvelc and editupvelc actions (#2044) * feat: add WIP files * feat: add editupvelc action * feat(configuration): add optional chaining for upvoteStartDateTime * feat(dao action): change UPVOTE string to const * refactor: combine upvelc actions into one * refactor: add separate array for upvelc actions * refactor(upvelc action): add empty cause --------- Co-authored-by: Irving Puga <[email protected]> * feat: add github actions for deploying eos mainnet and eos testnet in… (#2015) * feat: add github actions for deploying eos mainnet and eos testnet instances * feat: retrieve the configuration from github environment secrets and variables * fix: update the ppp-client-api library; add option to specify DGraph auth key * feat: add missing dgraph api key * fix: use the root dao id instead of the root document hash * feat(members): add community filter (#2035) * feat/upvote election flow (#2037) * feat(upvote-delegate-widget): added new upvote-delegate-widget with title and counter (#1943) * feat(upvote-delegate-widget): added user-card without icon and tag (#1943) * feat(upvote-delegate-widget): added head delegate tag and address-card icon (#1943) * feat(upvote-delegate-widget): update component story file (#1943) * feat(creation-stepper): added new prop title * feat(upvote-election): added new upvote-election route with sign-up screen (#1940) * feat(upvote-election): added new screen round-1 (#1940) * feat(upvote-election): added new screen chief delegates round (#1940) * feat(upvote-election): added new screen head delegate (#1940) * feat(upvote-election): added new screen results (#1940) * feat(upvote-election-banner): added upvote election banner(#1939) * fix(assets): assets grid after merge * feat(upvote-election): integrate graphql api for election * feat(upvote-election): integrate voting logic (intermediate commit) --------- Co-authored-by: Arsenije Savic <[email protected]> * fix: remove console.log (#2038) * fix/upvote election bugs (#2042) * fix(upvote-election): ability to unselect user and passing count (#2041) * fix(upvote-election): revoke action and one style bug * feat: retrieve the configuration from github environment secrets and variables * feat: replace Telos with EOS --------- Co-authored-by: arsenijesavic <[email protected]> Co-authored-by: Evgeni B <[email protected]> * feat: add github actions for deploying eos mainnet and eos testnet instances * feat: retrieve the configuration from github environment secrets and variables * feat: retrieve the configuration from github environment secrets and variables * feat: add github actions for deploying eos mainnet and eos testnet instances * feat: retrieve the configuration from github environment secrets and variables * feat: retrieve the configuration from github environment secrets and variables * feat: use DHO with EOS account * feat: add login with EOS * fix: replace hardcoded kv contract name with config variable * fix: remove hardcoded contract names * fix: add missing spaces, make lint happy * fix: add BASE_APP as app id * fix: force new deploy - rollback * fix(graphql): missed variable --------- Co-authored-by: Irving Puga <[email protected]> Co-authored-by: arsenijesavic <[email protected]> Co-authored-by: Alex <[email protected]>
* feat(mobile): add multi sig styles (#1997) * fix(proposal): remove edit button (#2006) * feat(login-view): add redirect when login via onboard (#2005) * fix(plan-manager): add correct linking for manage plan buttons (#2004) * fix(top-navigation): remove plan manager button (#2003) * fix(documentation-url): add dynamic links (#2002) * ci: remove documentation url from build (#2001) * refactor(calendar): return to quesar calendar (#2000) * feat(app-styl): add components module (#1996) * fix(comment-item): comment time since formating has been fixed (#1998) (#2008) * fix(proposal-detail): url preview (#1999) (#2009) * feat(badges): update card layout (#1981) (#2011) * feat(configuration-page): add community tab (#2013) * fix(style): rename rounded-corners to the rounded-full (#2016) * fix(badges): filter badge holders by dao (#2010) (#2014) * fix(badges): displaying active badges in dao page (#2018) (#2025) * fix(voting): vote button not visible in mobile design (#2019) (#2024) * fix(refactor): remove home page repeated template code * Revert "fix(refactor): remove home page repeated template code" This reverts commit 355d382. * fix(refactor): remove home page repeated template code (#2031) * fix(mobile): configration templates (#2030) * fix(mobile): general settings layout * fix(mobile): voting settings layout * fix(mobile): design settings layout * fix(mobile): plan settings layout * fix(mobile): communication config toggle * fix(mobile): buy token buttons * feat(members): add community filter (#2035) * feat/upvote election flow (#2037) * feat(upvote-delegate-widget): added new upvote-delegate-widget with title and counter (#1943) * feat(upvote-delegate-widget): added user-card without icon and tag (#1943) * feat(upvote-delegate-widget): added head delegate tag and address-card icon (#1943) * feat(upvote-delegate-widget): update component story file (#1943) * feat(creation-stepper): added new prop title * feat(upvote-election): added new upvote-election route with sign-up screen (#1940) * feat(upvote-election): added new screen round-1 (#1940) * feat(upvote-election): added new screen chief delegates round (#1940) * feat(upvote-election): added new screen head delegate (#1940) * feat(upvote-election): added new screen results (#1940) * feat(upvote-election-banner): added upvote election banner(#1939) * fix(assets): assets grid after merge * feat(upvote-election): integrate graphql api for election * feat(upvote-election): integrate voting logic (intermediate commit) --------- Co-authored-by: Arsenije Savic <[email protected]> * fix: remove console.log (#2038) * fix/upvote election bugs (#2042) * fix(upvote-election): ability to unselect user and passing count (#2041) * fix(upvote-election): revoke action and one style bug * feat(configuration page): add createupvelc and editupvelc actions (#2044) * feat: add WIP files * feat: add editupvelc action * feat(configuration): add optional chaining for upvoteStartDateTime * feat(dao action): change UPVOTE string to const * refactor: combine upvelc actions into one * refactor: add separate array for upvelc actions * refactor(upvelc action): add empty cause --------- Co-authored-by: Irving Puga <[email protected]> * feat: add github actions for deploying eos mainnet and eos testnet in… (#2015) * feat: add github actions for deploying eos mainnet and eos testnet instances * feat: retrieve the configuration from github environment secrets and variables * fix: update the ppp-client-api library; add option to specify DGraph auth key * feat: add missing dgraph api key * fix: use the root dao id instead of the root document hash * feat(members): add community filter (#2035) * feat/upvote election flow (#2037) * feat(upvote-delegate-widget): added new upvote-delegate-widget with title and counter (#1943) * feat(upvote-delegate-widget): added user-card without icon and tag (#1943) * feat(upvote-delegate-widget): added head delegate tag and address-card icon (#1943) * feat(upvote-delegate-widget): update component story file (#1943) * feat(creation-stepper): added new prop title * feat(upvote-election): added new upvote-election route with sign-up screen (#1940) * feat(upvote-election): added new screen round-1 (#1940) * feat(upvote-election): added new screen chief delegates round (#1940) * feat(upvote-election): added new screen head delegate (#1940) * feat(upvote-election): added new screen results (#1940) * feat(upvote-election-banner): added upvote election banner(#1939) * fix(assets): assets grid after merge * feat(upvote-election): integrate graphql api for election * feat(upvote-election): integrate voting logic (intermediate commit) --------- Co-authored-by: Arsenije Savic <[email protected]> * fix: remove console.log (#2038) * fix/upvote election bugs (#2042) * fix(upvote-election): ability to unselect user and passing count (#2041) * fix(upvote-election): revoke action and one style bug * feat: retrieve the configuration from github environment secrets and variables * feat: replace Telos with EOS --------- Co-authored-by: arsenijesavic <[email protected]> Co-authored-by: Evgeni B <[email protected]> * feat: add github actions for deploying eos mainnet and eos testnet instances * feat: retrieve the configuration from github environment secrets and variables * feat: retrieve the configuration from github environment secrets and variables * feat: add github actions for deploying eos mainnet and eos testnet instances * feat: retrieve the configuration from github environment secrets and variables * feat: retrieve the configuration from github environment secrets and variables * feat: use DHO with EOS account * feat: add login with EOS * fix: replace hardcoded kv contract name with config variable * fix: remove hardcoded contract names * fix: add missing spaces, make lint happy * fix: add BASE_APP as app id * fix: force new deploy - rollback * fix(upvote-banner): signup button title --------- Co-authored-by: Irving Puga <[email protected]> Co-authored-by: arsenijesavic <[email protected]> Co-authored-by: Alex <[email protected]>
* fix: missed graphql variable (#2057) * feat(mobile): add multi sig styles (#1997) * fix(proposal): remove edit button (#2006) * feat(login-view): add redirect when login via onboard (#2005) * fix(plan-manager): add correct linking for manage plan buttons (#2004) * fix(top-navigation): remove plan manager button (#2003) * fix(documentation-url): add dynamic links (#2002) * ci: remove documentation url from build (#2001) * refactor(calendar): return to quesar calendar (#2000) * feat(app-styl): add components module (#1996) * fix(comment-item): comment time since formating has been fixed (#1998) (#2008) * fix(proposal-detail): url preview (#1999) (#2009) * feat(badges): update card layout (#1981) (#2011) * feat(configuration-page): add community tab (#2013) * fix(style): rename rounded-corners to the rounded-full (#2016) * fix(badges): filter badge holders by dao (#2010) (#2014) * fix(badges): displaying active badges in dao page (#2018) (#2025) * fix(voting): vote button not visible in mobile design (#2019) (#2024) * fix(refactor): remove home page repeated template code * Revert "fix(refactor): remove home page repeated template code" This reverts commit 355d382. * fix(refactor): remove home page repeated template code (#2031) * fix(mobile): configration templates (#2030) * fix(mobile): general settings layout * fix(mobile): voting settings layout * fix(mobile): design settings layout * fix(mobile): plan settings layout * fix(mobile): communication config toggle * fix(mobile): buy token buttons * feat(members): add community filter (#2035) * feat/upvote election flow (#2037) * feat(upvote-delegate-widget): added new upvote-delegate-widget with title and counter (#1943) * feat(upvote-delegate-widget): added user-card without icon and tag (#1943) * feat(upvote-delegate-widget): added head delegate tag and address-card icon (#1943) * feat(upvote-delegate-widget): update component story file (#1943) * feat(creation-stepper): added new prop title * feat(upvote-election): added new upvote-election route with sign-up screen (#1940) * feat(upvote-election): added new screen round-1 (#1940) * feat(upvote-election): added new screen chief delegates round (#1940) * feat(upvote-election): added new screen head delegate (#1940) * feat(upvote-election): added new screen results (#1940) * feat(upvote-election-banner): added upvote election banner(#1939) * fix(assets): assets grid after merge * feat(upvote-election): integrate graphql api for election * feat(upvote-election): integrate voting logic (intermediate commit) --------- Co-authored-by: Arsenije Savic <[email protected]> * fix: remove console.log (#2038) * fix/upvote election bugs (#2042) * fix(upvote-election): ability to unselect user and passing count (#2041) * fix(upvote-election): revoke action and one style bug * feat(configuration page): add createupvelc and editupvelc actions (#2044) * feat: add WIP files * feat: add editupvelc action * feat(configuration): add optional chaining for upvoteStartDateTime * feat(dao action): change UPVOTE string to const * refactor: combine upvelc actions into one * refactor: add separate array for upvelc actions * refactor(upvelc action): add empty cause --------- Co-authored-by: Irving Puga <[email protected]> * feat: add github actions for deploying eos mainnet and eos testnet in… (#2015) * feat: add github actions for deploying eos mainnet and eos testnet instances * feat: retrieve the configuration from github environment secrets and variables * fix: update the ppp-client-api library; add option to specify DGraph auth key * feat: add missing dgraph api key * fix: use the root dao id instead of the root document hash * feat(members): add community filter (#2035) * feat/upvote election flow (#2037) * feat(upvote-delegate-widget): added new upvote-delegate-widget with title and counter (#1943) * feat(upvote-delegate-widget): added user-card without icon and tag (#1943) * feat(upvote-delegate-widget): added head delegate tag and address-card icon (#1943) * feat(upvote-delegate-widget): update component story file (#1943) * feat(creation-stepper): added new prop title * feat(upvote-election): added new upvote-election route with sign-up screen (#1940) * feat(upvote-election): added new screen round-1 (#1940) * feat(upvote-election): added new screen chief delegates round (#1940) * feat(upvote-election): added new screen head delegate (#1940) * feat(upvote-election): added new screen results (#1940) * feat(upvote-election-banner): added upvote election banner(#1939) * fix(assets): assets grid after merge * feat(upvote-election): integrate graphql api for election * feat(upvote-election): integrate voting logic (intermediate commit) --------- Co-authored-by: Arsenije Savic <[email protected]> * fix: remove console.log (#2038) * fix/upvote election bugs (#2042) * fix(upvote-election): ability to unselect user and passing count (#2041) * fix(upvote-election): revoke action and one style bug * feat: retrieve the configuration from github environment secrets and variables * feat: replace Telos with EOS --------- Co-authored-by: arsenijesavic <[email protected]> Co-authored-by: Evgeni B <[email protected]> * feat: add github actions for deploying eos mainnet and eos testnet instances * feat: retrieve the configuration from github environment secrets and variables * feat: retrieve the configuration from github environment secrets and variables * feat: add github actions for deploying eos mainnet and eos testnet instances * feat: retrieve the configuration from github environment secrets and variables * feat: retrieve the configuration from github environment secrets and variables * feat: use DHO with EOS account * feat: add login with EOS * fix: replace hardcoded kv contract name with config variable * fix: remove hardcoded contract names * fix: add missing spaces, make lint happy * fix: add BASE_APP as app id * fix: force new deploy - rollback * fix(graphql): missed variable --------- Co-authored-by: Irving Puga <[email protected]> Co-authored-by: arsenijesavic <[email protected]> Co-authored-by: Alex <[email protected]> * fix/upvote banner signup button (#2058) * feat(mobile): add multi sig styles (#1997) * fix(proposal): remove edit button (#2006) * feat(login-view): add redirect when login via onboard (#2005) * fix(plan-manager): add correct linking for manage plan buttons (#2004) * fix(top-navigation): remove plan manager button (#2003) * fix(documentation-url): add dynamic links (#2002) * ci: remove documentation url from build (#2001) * refactor(calendar): return to quesar calendar (#2000) * feat(app-styl): add components module (#1996) * fix(comment-item): comment time since formating has been fixed (#1998) (#2008) * fix(proposal-detail): url preview (#1999) (#2009) * feat(badges): update card layout (#1981) (#2011) * feat(configuration-page): add community tab (#2013) * fix(style): rename rounded-corners to the rounded-full (#2016) * fix(badges): filter badge holders by dao (#2010) (#2014) * fix(badges): displaying active badges in dao page (#2018) (#2025) * fix(voting): vote button not visible in mobile design (#2019) (#2024) * fix(refactor): remove home page repeated template code * Revert "fix(refactor): remove home page repeated template code" This reverts commit 355d382. * fix(refactor): remove home page repeated template code (#2031) * fix(mobile): configration templates (#2030) * fix(mobile): general settings layout * fix(mobile): voting settings layout * fix(mobile): design settings layout * fix(mobile): plan settings layout * fix(mobile): communication config toggle * fix(mobile): buy token buttons * feat(members): add community filter (#2035) * feat/upvote election flow (#2037) * feat(upvote-delegate-widget): added new upvote-delegate-widget with title and counter (#1943) * feat(upvote-delegate-widget): added user-card without icon and tag (#1943) * feat(upvote-delegate-widget): added head delegate tag and address-card icon (#1943) * feat(upvote-delegate-widget): update component story file (#1943) * feat(creation-stepper): added new prop title * feat(upvote-election): added new upvote-election route with sign-up screen (#1940) * feat(upvote-election): added new screen round-1 (#1940) * feat(upvote-election): added new screen chief delegates round (#1940) * feat(upvote-election): added new screen head delegate (#1940) * feat(upvote-election): added new screen results (#1940) * feat(upvote-election-banner): added upvote election banner(#1939) * fix(assets): assets grid after merge * feat(upvote-election): integrate graphql api for election * feat(upvote-election): integrate voting logic (intermediate commit) --------- Co-authored-by: Arsenije Savic <[email protected]> * fix: remove console.log (#2038) * fix/upvote election bugs (#2042) * fix(upvote-election): ability to unselect user and passing count (#2041) * fix(upvote-election): revoke action and one style bug * feat(configuration page): add createupvelc and editupvelc actions (#2044) * feat: add WIP files * feat: add editupvelc action * feat(configuration): add optional chaining for upvoteStartDateTime * feat(dao action): change UPVOTE string to const * refactor: combine upvelc actions into one * refactor: add separate array for upvelc actions * refactor(upvelc action): add empty cause --------- Co-authored-by: Irving Puga <[email protected]> * feat: add github actions for deploying eos mainnet and eos testnet in… (#2015) * feat: add github actions for deploying eos mainnet and eos testnet instances * feat: retrieve the configuration from github environment secrets and variables * fix: update the ppp-client-api library; add option to specify DGraph auth key * feat: add missing dgraph api key * fix: use the root dao id instead of the root document hash * feat(members): add community filter (#2035) * feat/upvote election flow (#2037) * feat(upvote-delegate-widget): added new upvote-delegate-widget with title and counter (#1943) * feat(upvote-delegate-widget): added user-card without icon and tag (#1943) * feat(upvote-delegate-widget): added head delegate tag and address-card icon (#1943) * feat(upvote-delegate-widget): update component story file (#1943) * feat(creation-stepper): added new prop title * feat(upvote-election): added new upvote-election route with sign-up screen (#1940) * feat(upvote-election): added new screen round-1 (#1940) * feat(upvote-election): added new screen chief delegates round (#1940) * feat(upvote-election): added new screen head delegate (#1940) * feat(upvote-election): added new screen results (#1940) * feat(upvote-election-banner): added upvote election banner(#1939) * fix(assets): assets grid after merge * feat(upvote-election): integrate graphql api for election * feat(upvote-election): integrate voting logic (intermediate commit) --------- Co-authored-by: Arsenije Savic <[email protected]> * fix: remove console.log (#2038) * fix/upvote election bugs (#2042) * fix(upvote-election): ability to unselect user and passing count (#2041) * fix(upvote-election): revoke action and one style bug * feat: retrieve the configuration from github environment secrets and variables * feat: replace Telos with EOS --------- Co-authored-by: arsenijesavic <[email protected]> Co-authored-by: Evgeni B <[email protected]> * feat: add github actions for deploying eos mainnet and eos testnet instances * feat: retrieve the configuration from github environment secrets and variables * feat: retrieve the configuration from github environment secrets and variables * feat: add github actions for deploying eos mainnet and eos testnet instances * feat: retrieve the configuration from github environment secrets and variables * feat: retrieve the configuration from github environment secrets and variables * feat: use DHO with EOS account * feat: add login with EOS * fix: replace hardcoded kv contract name with config variable * fix: remove hardcoded contract names * fix: add missing spaces, make lint happy * fix: add BASE_APP as app id * fix: force new deploy - rollback * fix(upvote-banner): signup button title --------- Co-authored-by: Irving Puga <[email protected]> Co-authored-by: arsenijesavic <[email protected]> Co-authored-by: Alex <[email protected]> --------- Co-authored-by: Evgeni B <[email protected]> Co-authored-by: Irving Puga <[email protected]> Co-authored-by: Alex <[email protected]>
🗃 Github Issue Or Explanation for this PR. (What is it supposed to do and Why is needed)
This PR adds createupvelc and editupvelc actions that manage the state of the election