Skip to content

Commit

Permalink
Issue #234: Use daemon threads for sending thread pool
Browse files Browse the repository at this point in the history
  • Loading branch information
hypfvieh committed Sep 21, 2023
1 parent 43d0e86 commit 7219193
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 14 deletions.
1 change: 1 addition & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -87,6 +87,7 @@ The library will remain open source and MIT licensed and can still be used, fork
- Improved logging and handling of disconnected transports in `DBusDaemon`, thanks to [brett-smith](https://github.com/brett-smith) ([#225](https://github.com/hypfvieh/dbus-java/issues/225))
- Added additional transport (dbus-java-junixsocket), thanks to [Prototik](https://github.com/Prototik) ([#227](https://github.com/hypfvieh/dbus-java/issues/227)) for providing the implementation
- Smaller refactorings to avoid code duplication for new transport
- Use daemon threads in `ExecutorService` for DBus-Sender-Threads ([#234](https://github.com/hypfvieh/dbus-java/issues/234))

##### Changes in 4.3.0 (2023-03-10):

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9,25 +9,16 @@
import org.freedesktop.dbus.errors.Error;
import org.freedesktop.dbus.errors.UnknownMethod;
import org.freedesktop.dbus.errors.UnknownObject;
import org.freedesktop.dbus.exceptions.DBusException;
import org.freedesktop.dbus.exceptions.DBusExecutionException;
import org.freedesktop.dbus.exceptions.FatalDBusException;
import org.freedesktop.dbus.exceptions.NotConnected;
import org.freedesktop.dbus.interfaces.CallbackHandler;
import org.freedesktop.dbus.interfaces.DBusInterface;
import org.freedesktop.dbus.interfaces.DBusSigHandler;
import org.freedesktop.dbus.exceptions.*;
import org.freedesktop.dbus.interfaces.*;
import org.freedesktop.dbus.messages.*;
import org.freedesktop.dbus.utils.LoggingHelper;
import org.freedesktop.dbus.utils.NameableThreadFactory;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;

import java.io.Closeable;
import java.io.EOFException;
import java.io.IOException;
import java.lang.reflect.InvocationTargetException;
import java.lang.reflect.Method;
import java.lang.reflect.Type;
import java.io.*;
import java.lang.reflect.*;
import java.nio.channels.ClosedByInterruptException;
import java.util.*;
import java.util.Map.Entry;
Expand Down Expand Up @@ -114,7 +105,7 @@ protected AbstractConnection(TransportConfig _transportConfig, ReceivingServiceC

receivingService = new ReceivingService(_rsCfg);
senderService =
Executors.newFixedThreadPool(1, new NameableThreadFactory("DBus Sender Thread-", false));
Executors.newFixedThreadPool(1, new NameableThreadFactory("DBus Sender Thread-", true));

objectTree = new ObjectTree();
fallbackContainer = new FallbackContainer();
Expand Down

0 comments on commit 7219193

Please sign in to comment.