Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: adapt for new GitHub color variables #785

Merged
merged 2 commits into from
Mar 23, 2024

Conversation

tyn1998
Copy link
Member

@tyn1998 tyn1998 commented Mar 22, 2024

Brief Information

This pull request is in the type of (more info about types):

  • build
  • ci
  • docs
  • feat
  • fix
  • perf
  • refactor
  • test

Related issues (all available keywords):

Details

image image image

Checklist

Others

@tyn1998 tyn1998 force-pushed the fix/background-color branch from e4ca14c to a103264 Compare March 22, 2024 14:53
@tyn1998
Copy link
Member Author

tyn1998 commented Mar 23, 2024

I found when users are not logged in, the GitHub UI is still in its old version, where CSS color variables don't change. So I also adapt the code for two set of CSS color variables.

image

Copy link
Collaborator

@wangyantong2000 wangyantong2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image image image image LGTM!

Copy link
Collaborator

@HalloMelon HalloMelon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it is normal in the dark system too 🚀 ~
image
image

@HalloMelon HalloMelon merged commit 54f7d7b into hypertrons:master Mar 23, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] background color is broken
3 participants