Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add script to generate proto on known version of protoc #290

Merged
merged 1 commit into from
Nov 14, 2022

Conversation

prodion23
Copy link
Collaborator

@prodion23 prodion23 commented Nov 14, 2022

Description

Protobuf version was previously based on user installed version of proto(as mentioned here):
#165

This creates issues when trying to bump proto versions, as generating protobuf on a newer version limits our supported minimum, even though in requirements.txt and setup.py we specify a ceiling.

For some reason httpx needs added to dev dependencies(since Friday it seems like something has changed) and 3.7+ tests continue to hang indefinitely

@codecov
Copy link

codecov bot commented Nov 14, 2022

Codecov Report

Merging #290 (bf885f3) into main (9ba081d) will increase coverage by 1.55%.
The diff coverage is 100.00%.

❗ Current head bf885f3 differs from pull request most recent head e8df9e2. Consider uploading reports for the commit e8df9e2 to get more accurate results

@@            Coverage Diff             @@
##             main     #290      +/-   ##
==========================================
+ Coverage   82.28%   83.84%   +1.55%     
==========================================
  Files          31       31              
  Lines        1558     1572      +14     
==========================================
+ Hits         1282     1318      +36     
+ Misses        276      254      -22     
Impacted Files Coverage Δ
src/hypertrace/agent/config/config_pb2.py 100.00% <100.00%> (+31.88%) ⬆️
src/hypertrace/version.py 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

tyroneyu
tyroneyu previously approved these changes Nov 14, 2022
@prodion23 prodion23 merged commit 6e6b457 into main Nov 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants