Feature - Notification unveil #108
Conversation
Fixes hyperoslo#101 and ensures that 2 line text increases the shouts height
…t fit in the shout notification
|
@tkohout, thanks for your PR! By analyzing the annotation information on this pull request, we identified @RamonGilabert and @onmyway133 to be potential reviewers |
| Dimensions.height = UIApplication.sharedApplication().statusBarHidden ? 70 : 80 | ||
|
|
||
| Dimensions.height = UIApplication.sharedApplication().statusBarHidden ? 55 : 65 | ||
There was a problem hiding this comment.
Could you go ahead and remove this whitespace? 😁
| @@ -218,15 +220,24 @@ public class ShoutView: UIView { | |||
| announcement.action?() | |||
| silent() | |||
| } | |||
|
|
|||
|
|
|||
| var subtitleLabelOriginalHeight: CGFloat = 0 | |||
There was a problem hiding this comment.
You should probably have this var at the top of the file instead of in between method declarations.
| if panGestureRecognizer.state == .Began { | ||
| subtitleLabelOriginalHeight = self.subtitleLabel.bounds.size.height | ||
| self.subtitleLabel.numberOfLines = 0 | ||
| self.subtitleLabel.sizeToFit() |
There was a problem hiding this comment.
Do you need to reference self here?
| @@ -235,14 +246,17 @@ public class ShoutView: UIView { | |||
| let height = translation.y < -5 || shouldSilent ? 0 : Dimensions.height | |||
|
|
|||
| duration = 0.2 | |||
|
|
|||
| self.subtitleLabel.numberOfLines = 2 | |||
| self.subtitleLabel.sizeToFit() | |||
There was a problem hiding this comment.
You can probably drop self here as well.
|
Thanks for the reply, I will send fixes for this and mentioned minor stuff over the weekend. Cheers |
|
Done. I added the required changes and fixed the issue with the orientation change. |
|
@tkohout thanks mate, this is great!
|
I have added new feature to unveil rest of the notification if it doesn't fit. Additionally I enlarged the gestureContainer to the whole area of notification. It does work similar as the apple system notifications.
Preview: