Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Modify test to remove flakiness caused by explicit uids #6080

Merged
merged 2 commits into from
Jul 28, 2020

Conversation

all-seeing-code
Copy link
Contributor

@all-seeing-code all-seeing-code commented Jul 27, 2020

Motivation

This PR fixes DGRAPH-1737
The test is modified to use query instead of exported uids to check xidmap's re-use with live loader. This removes the flakyness from the test.

Components affected by this PR

TestLoaderXidMap

Does this PR break backwards compatibility?

No.

Testing

It is a fix to the flaky test. Additional testing not required.

Fixes

Fixes DGRAPH-1737


This change is Reviewable

Copy link
Contributor

@pawanrawal pawanrawal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @ashish-goswami, @manishrjain, and @vvbalaji-dgraph)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants