Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pagination param "after" does not work when using func: uid(v) #6058

Closed
wants to merge 154 commits into from
Closed
Changes from 8 commits
Commits
Show all changes
154 commits
Select commit Hold shift + click to select a range
ef6f752
testing
Jul 22, 2020
74bd19d
testing
Jul 22, 2020
af5ad08
testing
Jul 22, 2020
81565ae
checking afterUID in case of UIDs also
Jul 22, 2020
d78d38b
Merge branch 'master' of https://github.com/dgraph-io/dgraph into nee…
Jul 23, 2020
5847518
swaped conditions in for loop
Jul 23, 2020
f7e42ca
shifted the after uid part inside else condition
Jul 23, 2020
bd2dfb7
changed if condition
Jul 23, 2020
fc5927b
chore: Add remove-orphans flag to docker compose and update tests to …
all-seeing-code Jul 23, 2020
eeb6187
wiki/deploy helm chart update (#6049)
darkn3rd Jul 23, 2020
b3b8f3e
chore: Print Zero config in logs. (#6047)
danielmai Jul 24, 2020
3cbfba1
skiping the flaky subscription test (#6069)
JatinDev543 Jul 24, 2020
52019d3
docs(Readme): current version from 1.1 to 20.03.4 (#6068)
gotjoshua Jul 24, 2020
33a7104
docs(build): Update latest docs to v20.03.4. (#6063)
danielmai Jul 24, 2020
c51d007
refactor: Simplify how list splits are tracked. (#5920)
martinmr Jul 24, 2020
3596cc8
using binary search to find index afterUID
Jul 26, 2020
3e3a53f
fix(GraphQL): Fix auth rewriting for nested queries when RBAC rule is…
Jul 27, 2020
b8197a3
fix(GraphQL): Remove github issues link from the error messages. (#6036)
pawanrawal Jul 27, 2020
d82ecb4
fix(GraphQL): fixes panic in update mutation without set & remove (#6…
abhimanyusinghgaur Jul 27, 2020
3f91f29
fix(GraphQL): fixes wrong query parameter value for custom field URL…
abhimanyusinghgaur Jul 27, 2020
91e28d5
chore(GraphQL): remove skipped tests (#6078)
abhimanyusinghgaur Jul 27, 2020
e45c296
test: Add extra assesrtions to reverse uid test. (#6061)
martinmr Jul 27, 2020
a5c469d
chore: Modify test to remove flakiness caused by explicit uids (#6080)
all-seeing-code Jul 28, 2020
dbe84ae
added a unit test and now considering the if condition also
Jul 28, 2020
601e837
fix(GraphQL): Disallow Subscription typename. (#6077)
JatinDev543 Jul 28, 2020
bcd1684
build(standalone): Add DGRAPH_VERSION to build different Dgraph versi…
danielmai Jul 28, 2020
768da25
chore(changelog): Changelog for 20.07.0 (#6111)
Jul 28, 2020
27ddeca
chore(version): Add release codename to version output. (#6113)
danielmai Jul 28, 2020
72e6a47
fix(GraphQL): fix bug in custom resolver, now body need not have all …
JatinDev543 Jul 29, 2020
6ecf91e
chore: Benchmark Auth queries and compare it with non Auth queries. (…
Jul 29, 2020
386665f
fix(dgraph): Fix empty string response for zero datetime (#6067)
ahsanbarkati Jul 30, 2020
9fb934a
fix(dgraph): Dgraph version picked from git tags on master (#5956)
Jul 30, 2020
8661bcc
fix to contrib prometheus where labelselector matching invalid dgraph…
darkn3rd Jul 30, 2020
117ac3c
feat(GraphQL): Custom logic now supports DQL queries (#6115)
abhimanyusinghgaur Jul 30, 2020
5e39c8a
fix(Debug): Do not calculate min max versions upfront (#6031)
manishrjain Jul 30, 2020
198f680
fix(GraphQL): fixes flaky TestCustomDQL (#6120)
abhimanyusinghgaur Jul 31, 2020
b8c83e5
feat: Live Loader Now Supports Slash GraphQL (#6117)
gja Jul 31, 2020
2a3b85c
fix(dgraph): Fix out of order issues with split keys in bulk loader. …
martinmr Aug 3, 2020
88651b4
docs: [Breaking] split the docs into smaller pages (#6079)
NamanJain8 Aug 4, 2020
665a545
docs(build): Set v20.07 docs as latest. (#6132)
danielmai Aug 4, 2020
9d7fc94
fix(Dgraph): Don't store start_ts in postings. (#6127)
martinmr Aug 4, 2020
aca0921
fix(rollups): rollup a batch if more than 2 seconds elapsed since las…
Aug 4, 2020
e199e55
fix(dgraph): Fixes misleading error about invalid hostname (#6037)
ahsanbarkati Aug 6, 2020
bb8e4b9
fix(GraphQL): Fix getType queries when id was used as a name for type…
pawanrawal Aug 6, 2020
885ef67
fix(bulk loader): Remove redundant option set (#6119)
Aug 6, 2020
fa013db
fix(Dgraph): Perform rollups more aggresively. (#6143)
martinmr Aug 6, 2020
898a8f3
feat(dgraph): Add suport for RDF query. (#6038)
poonai Aug 7, 2020
37823e9
fix(GraphQl): Panic fix when subscription expiry is not present in jw…
JatinDev543 Aug 7, 2020
3ea5efe
Queue keys for rollup during mutation. (#6145)
martinmr Aug 7, 2020
223238a
chore(compose): Set multiple Zero addresses in Alpha. (#6144)
darkn3rd Aug 7, 2020
d1c3cd7
feat: add metrics cost to grpc and http header (#6148)
poonai Aug 10, 2020
0b4cd73
docs: document upgrade and internal type/predicate namespace (#6149)
abhimanyusinghgaur Aug 12, 2020
d807eb7
fix(GraphQl): Allow case insensitive auth header for graphql subscrip…
JatinDev543 Aug 12, 2020
0d49e10
feat(GraphQL): @custom HTTP body now supports hardcoded scalars (#6157)
abhimanyusinghgaur Aug 12, 2020
ccbc89c
docs(vault): Vault docs (#6163)
Aug 13, 2020
5ecef43
Revert "fix(Dgraph): Don't store start_ts in postings. (#6127)" (#6181)
Aug 13, 2020
54907b8
fix: Don't allow idx flag to be set to 0 on dgraph zero (#6156)
Aug 14, 2020
d6975fd
Prevent empty values in fields having `id` directive. (#6177)
Aug 14, 2020
fd0b4ad
feat(docs): Merge GraphQL docs (#6169)
vardhanapoorv Aug 14, 2020
5349aa1
fix deploy page to not show blank page (#6188)
NamanJain8 Aug 14, 2020
4ee4af8
Fix URL paths (#6189)
vardhanapoorv Aug 14, 2020
b601686
chore: Suport running bank test against slash (#6187)
gja Aug 14, 2020
2ddc036
Change URL path to absolute (#6190)
vardhanapoorv Aug 14, 2020
14adee1
docs: kubernetes prometheus update (#6133)
darkn3rd Aug 14, 2020
fa5f883
chore: Prometheus helm chart values (#6128)
darkn3rd Aug 14, 2020
deb70a3
feature: dgraph_txn_aborts metric for prometheus (#6171)
darkn3rd Aug 14, 2020
10aa819
Fix error message for idx = 0 for dgraph zero (#6198)
Aug 17, 2020
9b67c2f
fix(GraphQL): Don't reserve certain queries/mutations/inputs when a t…
pawanrawal Aug 17, 2020
806a8df
fix(GraphQL): Linking of xids for deep mutations (#6172)
pawanrawal Aug 17, 2020
e33bb1d
feat(live): added upsert in live loader (#6057)
harshil-goel Aug 17, 2020
fbbd731
fix(Dgraph): Don't store start_ts in postings. (#6206)
martinmr Aug 17, 2020
18ce64a
feat(GraphQL): GraphQL now has Int64 as scalar type (#6200)
abhimanyusinghgaur Aug 18, 2020
c8894bb
Add docs for GraphQL fragments. (#6224)
Aug 18, 2020
549557b
Add docs for GraphQL variables. (#6223)
Aug 18, 2020
a5bfd4a
fix(GraphQL): Fix order and offset in auth queries. (#6221)
Aug 18, 2020
120f338
Update badger to v2.2007.1 (#6229)
Aug 18, 2020
71fc82f
Update CHANGELOG for 20.07.1, 20.03.5, 1.2.7 (#6220)
lgalatin Aug 18, 2020
395695e
fix CL (#6236)
Aug 18, 2020
6059d8a
doc: Adding docs about ratel and Slash (#6241)
gja Aug 19, 2020
67a221a
doc: fixing a small typo
gja Aug 19, 2020
ea15b66
fix(Dgraph): make backups cancel other tasks (#6152)
martinmr Aug 19, 2020
93f3f0f
doc: Setting the canonical path to each docs without version (#6249)
gja Aug 20, 2020
fd5b392
fix: remove unnecessary curly braces from doc (#6256)
Aug 21, 2020
0faae40
docs: add info about __typename in custom DQL (#6248)
abhimanyusinghgaur Aug 21, 2020
dcce8bf
fix(GraphQL): fixes unexpected fragment behaviour (#6228)
abhimanyusinghgaur Aug 21, 2020
5f5aa9c
fix(Dgraph): Stop forcing RAM mode for the write-ahead log. (#6142)
martinmr Aug 21, 2020
42a5968
docs: cluster_checklist doc update (#6252)
darkn3rd Aug 21, 2020
7ac7af6
docs(releases): Update v20.07, 20.03, and 1.2 releases in Releases pa…
lgalatin Aug 22, 2020
c8b73e3
feat(GraphQL): add has filter support (#6258)
minhaj-shakeel Aug 24, 2020
ccfa6a4
feat(Dgraph): Add experimental cache for posting lists (#6245)
martinmr Aug 24, 2020
c79a835
docs: Improve the docs of delete mutation (#6257)
ahsanbarkati Aug 24, 2020
f31c5fb
docs: update kubernetes section (#6254)
darkn3rd Aug 24, 2020
7820d71
feat: add dynamic cors support (#6174)
poonai Aug 25, 2020
e9dda24
Enabling Discuss comments
gja Aug 25, 2020
cd1dbeb
Feat(GraphQL): This PR adds parameterised cascade in graphql. (#6251)
JatinDev543 Aug 26, 2020
3638c12
Fix(Dgraph): Fix how visited nodes are detected in recurse queries. (…
martinmr Aug 26, 2020
df63d6c
fix(Dgraph): Sort manifests by BackupNum in file handler. (#6263)
martinmr Aug 26, 2020
d3bee33
fix(GraphQL): fix internal error when doing GraphQL schema introspect…
minhaj-shakeel Aug 27, 2020
079a0de
feat: add --cache_mb and --cache_percentage flag (#6271)
NamanJain8 Aug 27, 2020
12b2716
fix(GraphQL): Link xids properly if there are duplicate xids within t…
pawanrawal Aug 27, 2020
cb2eec2
fixed schema documentation section (#6289)
anand-chandrashekar Aug 27, 2020
3cea0fe
fix(task): Return error on closed DB (#6075)
Aug 27, 2020
52e136f
fix panicwrap parent check (#6264)
Aug 27, 2020
57fcd92
change behavior of param cascade to allow parent's cascade (with or w…
Aug 27, 2020
6f883a4
fix(ACL Query): Fixes queries which use variable at the top level (#6…
all-seeing-code Aug 27, 2020
a8a6e85
fix: Online Restore honors credentials passed in (#6295)
gja Aug 27, 2020
86d443d
disable compression for WAL (#6255)
NamanJain8 Aug 28, 2020
dcf9f12
chore(contrib/bank): Add flag to change how frequent checks are run. …
danielmai Aug 28, 2020
9ab8768
Revert "Fix(Dgraph): Fix how visited nodes are detected in recurse qu…
martinmr Aug 28, 2020
f1941b3
Fix(Alpha): MASA: Make Alpha Shutdown Again (#6313)
manishrjain Aug 29, 2020
c5721f6
chore(contrib/bank): Fix logging. (#6318)
danielmai Aug 29, 2020
2de4675
Fix(increment): Fix readTs less than minTs (#6317)
manishrjain Aug 29, 2020
deded8b
posting list changes. (#6303)
martinmr Aug 31, 2020
1783e0e
chore(compose): Specify version for tracing/metrics images. (#6139)
danielmai Aug 31, 2020
501f338
fix(Query) Fix Star_All delete query when used with ACL enabled (#6331)
all-seeing-code Aug 31, 2020
5b79260
Fix(Dgraph): Add a lock to backups to process one request at a time. …
martinmr Aug 31, 2020
bf79999
fix(Dgraph): Add flags to set table and vlog loading mode for zero. (…
martinmr Aug 31, 2020
4b375b3
fix(Dgraph): Replace fmt.Sprintf with strconv.FormatUint int outputrd…
martinmr Sep 1, 2020
844f34d
proto fix needed for PR #6331 (#6337)
Sep 1, 2020
d799fd0
feat(ludicrous): Run mutations from the same predicate concurrently i…
harshil-goel Sep 1, 2020
536b317
test: add --build option for docker-compose up in test script (#6348)
abhimanyusinghgaur Sep 1, 2020
0f3bfb1
fix(GraphQl): fix errors from authorization examples given in docs. (…
JatinDev543 Sep 1, 2020
31ac3b4
testing
Jul 22, 2020
40281b0
testing
Jul 22, 2020
29a2bd2
testing
Jul 22, 2020
7cb4e77
checking afterUID in case of UIDs also
Jul 22, 2020
4cdaef5
swaped conditions in for loop
Jul 23, 2020
f8b290f
shifted the after uid part inside else condition
Jul 23, 2020
5f81ea8
changed if condition
Jul 23, 2020
bdd072b
using binary search to find index afterUID
Jul 26, 2020
4a87e2f
added a unit test and now considering the if condition also
Jul 28, 2020
a513988
added another test with uid variable at another level than root
Sep 1, 2020
d9f6e30
Merge branch 'neeraj/paginationUID' of https://github.com/dgraph-io/d…
Sep 1, 2020
8074db6
updated the second test
Sep 1, 2020
089f699
testing
Jul 22, 2020
c2ce605
testing
Jul 22, 2020
7b874fe
testing
Jul 22, 2020
8a57375
checking afterUID in case of UIDs also
Jul 22, 2020
2205c92
swaped conditions in for loop
Jul 23, 2020
d09fd1a
shifted the after uid part inside else condition
Jul 23, 2020
f241851
changed if condition
Jul 23, 2020
16a8fc4
using binary search to find index afterUID
Jul 26, 2020
b98c21a
added a unit test and now considering the if condition also
Jul 28, 2020
d3f2991
added another test with uid variable at another level than root
Sep 1, 2020
7a75af2
testing
Jul 22, 2020
f13e2c0
testing
Jul 22, 2020
91c8b98
testing
Jul 22, 2020
05700a0
checking afterUID in case of UIDs also
Jul 22, 2020
10704ed
shifted the after uid part inside else condition
Jul 23, 2020
f73b164
changed if condition
Jul 23, 2020
826eb9d
using binary search to find index afterUID
Jul 26, 2020
2e7231b
added a unit test and now considering the if condition also
Jul 28, 2020
2ddf748
updated the second test
Sep 1, 2020
e811ae0
Merge branch 'neeraj/paginationUID' of https://github.com/dgraph-io/d…
Sep 1, 2020
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions query/query.go
Original file line number Diff line number Diff line change
Expand Up @@ -2009,6 +2009,13 @@ func ProcessGraph(ctx context.Context, sg, parent *SubGraph, rch chan error) {
sort.Slice(sg.DestUIDs.Uids, func(i, j int) bool {
return sg.DestUIDs.Uids[i] < sg.DestUIDs.Uids[j]
})
if sg.Params.AfterUID > 0 {
i := 0
for i < len(sg.DestUIDs.Uids) && sg.DestUIDs.Uids[i] <= sg.Params.AfterUID {
i++
}
sg.DestUIDs.Uids = sg.DestUIDs.Uids[i:]
}
}
case sg.Attr == "":
// This is when we have uid function in children.
Expand Down